-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QOL Remove unnecessary clickable areas from PostListingList #710
QOL Remove unnecessary clickable areas from PostListingList #710
Conversation
The PostListingList is too small to have multiple clickable areas, leading many users to accidentally click into the community or the users profile from the front page instead of opening the post like they intended.
showDefaultIcon = false, | ||
) | ||
DotSpacer(0.dp) | ||
} | ||
PersonProfileLink( | ||
person = postView.creator, | ||
isModerator = isModerator, | ||
onClick = onPersonClick, | ||
onClick = {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good idea. Now users won't be able to go to a person's profile, or a community, from the post listing, at all.
@twizmwazin thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think people need or want to go to a users profile from the front page. If they want to, they can open the post and click through from there.
Take a look at the linked discussion thread, over 100 upvotes and almost 20 people commenting that this is also annoying them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was na issue opened about this, I'll link it here if I can find it. Users (including myself) accidentally fat-finger the small touch targets frequently and it is a bit of an annoyance. It is simple enough to open the post and then click the appropriate link from in there. An option wouldn't be a bad idea, which is what I think Boost does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the issue: #488
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmk, I spose its fine, especially since this just affects the list version.
@ZJouba You're right, but there are many users who prefer a more compact layout, myself included, who would prefer this approach. Settings in the future could be a nice way to accommodate both preferences. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once rebased
showDefaultIcon = false, | ||
) | ||
DotSpacer(0.dp) | ||
} | ||
PersonProfileLink( | ||
person = postView.creator, | ||
isModerator = isModerator, | ||
onClick = onPersonClick, | ||
onClick = {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmk, I spose its fine, especially since this just affects the list version.
With these changes, does clicking over a username or community name go to the underlying post instead, or does it just ignore the click and do nothing? I think the former would be a better experience for users. |
Clicking a username opens the post |
The PostListingList is too small to have multiple clickable areas, leading many users to accidentally click into the community or the users profile from the front page instead of opening the post like they intended.
https://lemmy.ml/post/1303517
Fixes #488