Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compose bom #1576

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Bump compose bom #1576

merged 3 commits into from
Jul 3, 2024

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jul 2, 2024

No description provided.

@MV-GH MV-GH requested a review from dessalines as a code owner July 2, 2024 23:41
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Surprised that renovate didn't pick this one up.

Edit: actually nm, its not finding that deployed yet.

@MV-GH
Copy link
Collaborator Author

MV-GH commented Jul 3, 2024

Strange it has been released a week ago

https://github.com/chrisbanes/compose-bom/releases

I can see it on mavencentral https://mvnrepository.com/artifact/dev.chrisbanes.compose/compose-bom

@@ -112,7 +112,7 @@ dependencies {
// https://github.com/LemmyNet/jerboa/pull/1502#issuecomment-2137935525
// val composeBom = platform("androidx.compose:compose-bom:2024.05.00")

val composeBom = platform("dev.chrisbanes.compose:compose-bom:2024.05.00-alpha03")
val composeBom = platform("dev.chrisbanes.compose:compose-bom:v2024.06.00-alpha01")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet its because you have a v2024, it should be just 2024....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it.

app/build.gradle.kts Outdated Show resolved Hide resolved
@dessalines dessalines enabled auto-merge (squash) July 3, 2024 14:41
@dessalines dessalines merged commit 601b118 into LemmyNet:main Jul 3, 2024
1 check passed
@MV-GH MV-GH deleted the bump-compose-bom branch July 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants