Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1533 use M3 PullToRefresh #1534

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Fix #1533 use M3 PullToRefresh #1534

merged 1 commit into from
Jun 1, 2024

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented May 31, 2024

I like the API of the new one, much simpler

Fix #1533

@MV-GH MV-GH requested a review from dessalines as a code owner May 31, 2024 22:24
@@ -690,44 +653,26 @@ fun InboxTabs(
}
}

val loading = inboxViewModel.messagesRes.isLoading()
val refreshing = inboxViewModel.mentionsRes.isRefreshing()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was incorrect before

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thx.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo much cleaner, thx for this.

@@ -690,44 +653,26 @@ fun InboxTabs(
}
}

val loading = inboxViewModel.messagesRes.isLoading()
val refreshing = inboxViewModel.mentionsRes.isRefreshing()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thx.

@dessalines dessalines merged commit 17e2343 into LemmyNet:main Jun 1, 2024
1 check passed
@MV-GH MV-GH deleted the ft/1533 branch June 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace M1 pullRefresh with M3 PullToRefresh
2 participants