Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use marquee for instance in topbar, and add it to communitysidebar #1107

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jul 27, 2023

I prefer this over the ellipsis

studio64_qSgARiKF5N.mp4

@twizmwazin
Copy link
Contributor

I'm not sure I like it tbh. I'd rather have a long-press action that revealed the full name if needed rather than have it persistently scrolling.

@MV-GH
Copy link
Collaborator Author

MV-GH commented Jul 27, 2023

It only does the scrolling thing when names are too long 99% it does not show, and any other action needs UX changes so that users will know they can do an action

Copy link
Contributor

@twizmwazin twizmwazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

@twizmwazin twizmwazin enabled auto-merge (squash) August 2, 2023 15:09
@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 2, 2023

Tbh I am not a fan of it either but I still prefer it over the ellipsis thing as the point of these changes are so that you can see the instance that community is from. And ellipsis prevents it. Ideally we add it somewhere else on a better place. And then we can revert these topbar changes and have it the name only. But this works for now.

@twizmwazin twizmwazin merged commit 0e6fd51 into LemmyNet:main Aug 2, 2023
@MV-GH MV-GH deleted the feat/instance_to_community branch August 7, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants