Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add divider to section for report actions #1064

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jul 19, 2023

Someone kept accidantally reporting posts instead of sharing it, So I moved it to the bottom and added a small section for it.

Tbh all those dialogs need to be redone at some point to add subnavigation menus because it is getting to big and that padding at the bottom is annoying. Maybe we should use https://m3.material.io/components/menus/guidelines#691d98ba-0375-4681-8c47-a5c3e7b58798

How it looks now
N22YDUP2Gy

I had recently added the missing old sort type but I had used the wrong icon. Now it has the same icon as the old sort used already somewhere.

Copy link
Contributor

@twizmwazin twizmwazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be more padding around the separator. I also think report might want to go before block community/user, though that's more subjective.

@MV-GH
Copy link
Collaborator Author

MV-GH commented Jul 19, 2023

image
Updated the padding

@MV-GH MV-GH requested a review from twizmwazin July 19, 2023 22:16
@twizmwazin twizmwazin merged commit 801de4c into LemmyNet:main Jul 20, 2023
@MV-GH MV-GH deleted the other/reorder_options branch July 20, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants