Some minor ports of commits from #354 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leleat
changed the title
Leleat
force-pushed
the
cherry-pick-from-354
branch
from
beb57e9 to
37427d5
Compare
The xAnchor parameter was used to restore the size of a window while keeping the titlebar at the relative x position. Our extra calculations were no longer needed (and also were no longer working) since GNOME 44 (https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2942). So remove that code.
eventually, I want to get rid of the signal class since that was a dumb "custom implementation of signal tracking". We could just directly attach the signals to the window instances or whatever...
This will allow for a more pleasant dev experience by adding better auto-complete and typing. Especially, for custom properties and methods that are injected into GNOME's objects. This is probably also the extent of 'typing' I plan to add. I don't intend to enable `checkJs` nor do I plan to transition to Typescript.
I've temporarily enabled `checkJs` and this uncovered some issues. They were mostly wrong JSDoc comments. But there were also some actual issues although I don't think they had observable bugs: - GLib.PRIORITY_IDLE -> GLib.PRIORITY_DEFAULT_IDLE ... PRIORITY_IDLE doen't exists - removed unused variables in calls to focusHint.js::getAbsPos - added a missing argument to addGaps call in tileEditingMode.js - fix import for debugging shortcut in utility.js (Also remove brackets in extension.js to satisfy the linter)
Leleat
force-pushed
the
cherry-pick-from-354
branch
from
37427d5 to
a2358b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.