forked from pontem-network/ledger-app-aptos
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop into main #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always inform about the blind signing, even if the option is activated in the settings.
- Invite users to enable the blind signing setting during the signature request. - Minor refactoring.
- Define the common code - Prepare resources -- Remove standard icons -- Add new icon templates
- Add MAX_TRANSACTION_PACKETS to Makefile for TARGET_STAX - Separate the common UI code - Put general functions into utils - Refactor BAGL UI (display, menu, settings) - Implement NBGL UI (display, menu, settings)
- Add Aptos icon - Fix typo on Blind Signing warning screen
style checks, documentation generation, clang static analyzer, Python client checks, CodeQL checks, build and functional tests.
This reverts commit f895edd.
- Parse `0x1::aptos_account::transfer_coins` function - Now show "Transaction Type" for all entry_function calls - Update gloden snapshots for tests
Support for non-UTF8 message signature
- Fix clang static analyzer warnings - Fix formatting - Disable blind signing after passing the test that activated it
Support for non-UTF8 message signature. Fixes.
Version v0.6.9: SDK upgrade, Ledger Stax UI, Improve Blind Signing behavior
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
===========================================
- Coverage 63.46% 42.24% -21.23%
===========================================
Files 13 5 -8
Lines 802 419 -383
===========================================
- Hits 509 177 -332
+ Misses 293 242 -51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.