Add chat damage breakdown, absorb hp/mp actions #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Azurelol
commented
Jan 30, 2025
•
Azurelol
commented
- Overhauls the damage breakdown on chat to be toggled on a click of the info button
- Adds 2 actions for absorbing half of damage dealt as HP or MP as context menu options
- Adds a helper for registering context menu items
- Add revert for resource gain chat messages
…th/mind leech on damage taken.
Azurelol
force-pushed
the
add/chat_damage_breakdown
branch
from
acb2840 to
d71f0a2
Compare
|
As requested, here's the latest css styles shown in the following example: Note that this currently expects a container element with the .project-fu class, and especially that is uses style variables from pfu-theme -- these would probably need to be updated for general system use. .project-fu table {
border-top: 1px solid var(--pfu-color-app-control-border);
border-bottom: 1px solid var(--pfu-color-app-control-border);
& thead {
background: var(--pfu-color-app-control-fill);
color: var(--pfu-color-app-control-content);
border-bottom: 1px solid var(--pfu-color-app-control-border);
}
& caption {
caption-side: top;
font-weight: bold;
color: inherit;
}
& th:first-child {
text-align: right;
}
& th, td {
text-align: left;
}
} |
Shourn
requested changes
Feb 1, 2025
module/pipelines/damage-pipeline.mjs
Outdated
| */ | ||
| recordStep(step, effect, total) { | ||
| this.breakdown.push({ | ||
| step: InlineHelper.nicifyString(step), |
There was a problem hiding this comment.
This should use localization.
There was a problem hiding this comment.
As mentioned in the other message, I would like to handle localization for this in the near future.
module/helpers/inline-helper.mjs
Outdated
| @@ -164,11 +185,22 @@ function capitalize(word) { | |||
| return word.charAt(0).toUpperCase() + word.slice(1).toLowerCase(); | |||
| } | |||
|
|
|||
| function nicifyString(str) { | |||
There was a problem hiding this comment.
Using proper localization makes this obsolete
There was a problem hiding this comment.
I would like to consider how to localize the different data model properties at another time.
| const attributeKey = dataset.key; | ||
| const updates = []; | ||
| updates.push(actor.modifyTokenAttribute(attributeKey, -amount, true)); | ||
| actor.showFloatyText(`${amount} ${dataset.resource.toUpperCase()}`, `red`); |
There was a problem hiding this comment.
This should use localization.
templates/chat/chat-apply-damage.hbs
Outdated
| <section id="breakdown" class="hidden"> | ||
| <div class='projectfu'> | ||
| <table> | ||
| <caption>Breakdown</caption> |
templates/chat/chat-apply-damage.hbs
Outdated
| <caption>Breakdown</caption> | ||
| <thead> | ||
| <tr> | ||
| <th>Step</th> |
templates/chat/chat-apply-damage.hbs
Outdated
| <thead> | ||
| <tr> | ||
| <th>Step</th> | ||
| <th>Effect</th> |
templates/chat/chat-apply-damage.hbs
Outdated
| <tr> | ||
| <th>Step</th> | ||
| <th>Effect</th> | ||
| <th>Total</th> |
As it does not scale the MP cost but handles multi-targeting
- add localization to calculation steps - remove outgoing damage, its already factored into the initial damage
…add/chat_damage_breakdown
Shourn
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.