Cleanup data models #201
Merged
Cleanup data models #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have a few more to go 😃 |
- refactor accessory chat card rendering - clean up accessory data model
- refactor armor chat card rendering - clean up armor data model
- refactor behavior chat card rendering
- refactor class chat card rendering
- refactor consumable chat card rendering
- refactor heroic skill chat card rendering - clean up heroic skill data model
- refactor project chat card rendering - clean up project data model
- refactor misc ability checksv2 integration - refactor misc ability chat card rendering - clean up misc ability model
- refactor ritual checksv2 integration - refactor ritual chat card rendering - clean up ritual sheet - clean up ritual model
- change zero power item type (not feature type) chat card rendering
- refactor rule chat card rendering
- refactor treasure chat card rendering
- give all models another pass - factor out more common sections
Shourn
force-pushed
the
refactor/data-model-cleanup
branch
from
2145ed9 to
fb247f7
Compare
KSops
reviewed
Jan 18, 2025
KSops
reviewed
Jan 18, 2025
KSops
reviewed
Jan 18, 2025
KSops
reviewed
Jan 18, 2025
KSops
approved these changes
Jan 18, 2025
Azurelol
approved these changes
Jan 18, 2025
- address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding proper ChecksV2 rendering to "non-combat" data models.
Also cleaning up old and unused data fields.