Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline weapon command #198

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Add inline weapon command #198

merged 6 commits into from
Jan 14, 2025

Conversation

Azurelol
Copy link
Collaborator

@Azurelol Azurelol commented Jan 9, 2025

  • Adds a command to apply effects on a given actor's weapon. If they have more than one weapon equipped it brings up the dialog to choose which to apply. Once the weapon alteration effect has been applied onto the item, it applies a linked effect on the actor which tracks that of the item. When the effect on the actor is removed, it will likewise remove it on the item.
  • Refactors the effect classes to delineate responsibility lines, moving several classes and functions out of the existing inline-effects file onto their separate files for clarity.
  • Added the Effects definition which should contain the bulk of the methods for dealing with active effects in the system. This is a first pass on that cleanup as I did not want the PR to get any bigger.
  • Fixes bug with evaluating expressions that was introduced in the check expression support feature.

image

- Refactor the effects classes for clarity
- Fix effects that are not statuses not being cleared by Clear
@Azurelol Azurelol changed the base branch from main to dev January 11, 2025 16:07
@Azurelol Azurelol marked this pull request as ready for review January 11, 2025 16:08
@Shourn Shourn self-requested a review January 12, 2025 11:47
- remove effect linking, instead show active temp effects from equipped items on actor sheet
- refactoring
@Shourn Shourn merged commit f4ece91 into dev Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants