Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom expressions in active effects #193

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add support for custom expressions in active effects #193

merged 1 commit into from
Jan 9, 2025

Conversation

Azurelol
Copy link
Collaborator

@Azurelol Azurelol commented Jan 2, 2025 •
edited
Loading

  • Provides support for evaluating expressions using our custom DSL within active effect values. This allows us to easily automate skills like defensive mastery.
  • Standardizes adding the damage and accuracy bonuses with the CheckConfigurer API across the various data models (mostly)
  • Add a button to revert damage on damage message

@Azurelol Azurelol changed the base branch from main to dev January 2, 2025 19:49
@Azurelol Azurelol marked this pull request as ready for review January 3, 2025 14:40
@Azurelol Azurelol force-pushed the add/active_effect_expressions branch from 3d30aea to 75f32d5 Compare January 9, 2025 18:16
@Azurelol Azurelol force-pushed the add/active_effect_expressions branch from 75f32d5 to 8f58962 Compare January 9, 2025 18:19
@Azurelol Azurelol merged commit d3166b5 into dev Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Azurelol