Fix inline source usage for events #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSops
reviewed
Dec 23, 2024
module/expressions/expressions.mjs
Outdated
| return context.actor.system.level.value; | ||
| // Item level / skill level | ||
| case 'il': | ||
| case 'sl': | ||
| assertItemInContext(context, match); | ||
| context.assertActor(match); |
There was a problem hiding this comment.
Ack! Thank you for catching it.
KSops
approved these changes
Dec 25, 2024
spyrella
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where the actor's methods could not be resolved for drag events.
It came to be due to non-primitives being passed in the
.dragstartevent, which get serialized then deserialized without type information.I had to refactor the events and the API involved so that we only pass in the uuids for the item/actor instead then resolve it at the very end.