Add support for improvised effect calculation on inline damage and resource gain/loss #180
Conversation
module/helpers/improvised-effect.mjs
Outdated
| /** | ||
| * Tier: Effect [Minor,Heavy,Massive] | ||
| */ | ||
| const amountPerTier = [ |
There was a problem hiding this comment.
Isn't directly clear how this data structure is organized at first glance. Comment could be interpreted as the first index being minor/heavy/massive.
There was a problem hiding this comment.
Good point. I will rewrite this comment for improved clarity.
module/helpers/improvised-effect.mjs
Outdated
| function calculateAmountFromContext(dataset, source, targets) { | ||
| const effect = dataset.effect; | ||
| if (effect === undefined) { | ||
| return Number(dataset.amount); |
There was a problem hiding this comment.
If dataset.amount is undefined, it looks like this produces NaN.
The JSDoc indicates the return should be null on failure.
There was a problem hiding this comment.
Ack. Thanks, will fix.
module/helpers/improvised-effect.mjs
Outdated
| } | ||
|
|
||
| const amount = ImprovisedEffect.calculateAmount(level, effect); | ||
| console.info(`Calculated amount for level ${level}, effect ${effect} = ${amount}`); |
There was a problem hiding this comment.
nit: console.debug might help reduce console clutter
There was a problem hiding this comment.
Whoops. Sorry, did not mean to commit this here. I will remove.
module/helpers/improvised-effect.mjs
Outdated
| level = source.system.level.value; | ||
| } else { | ||
| if (targets.length > 0) { | ||
| level = targets.reduce((a, b) => b.system.level.value > a.system.level.value); |
There was a problem hiding this comment.
This is intended to return the highest level of targets? Couldnt get the reduce to work in a minimal example
There was a problem hiding this comment.
Yes, to take the highest level.
There was a problem hiding this comment.
I think something closer to this might achieve the max level (stolen from AI):
let maxValue = targets.reduce((max, target) => {
return Math.max(max, target.system.level.value);
}, -Infinity); // Start with negative infinity to ensure any number is higher
There was a problem hiding this comment.
Done. It worked correctly as well.
|
Sorry for the late follow-up; will address your feedback now. |
|
Thank for your feedback, @KSops ! |
|
Thanks for the great addition! |
Adds support for using improvised effect into the following inline command ,where improvised effect:
$effect:
Minor|Heavy|Massive@DMG[$number $type],@DMG[$effect $type]@GAIN[$number $type]@GAIN[$effect $type]@LOSS[$number $type],@LOSS[$effect $type]This allows having spells/skills scale to the level of the source within the following ranges:
The amount calculated from an improvised effect is a simple mapping between the level range and the effect "potency" where the level is calculated based on the owner of the item. This works equally for spells, skills and active effects. (When an active effect is dropped on an actor, that becomes its source)
Example:
