Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Twin Shield Tweaks #152

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

MattByName
Copy link
Contributor

Hi there,

I made some tweaks to the Guardian Twin Shields ability as the book says that 'you gain the benefits of both items' (197) but in the compendium the bonus was only being applied once. I also added a Twin Shields item for when the player has one runic and one bronze shield

Changes

  • Twin Shields > set def bonus to 4
  • Twin Shields (Runic) > set def to 4, set magic def to 4
  • Twin Shields (Runic & Bronze) > set def to 4 and magic def to 2

Sorry if I've misunderstood the conventions on how you're building items. Thanks for all your hard work, the system is looking great.

increased the hp and mp boost to 4 each
changed hp bonus to 2 as this effect should stack
added twin shields for combining one runic shield with one bronze shield
@spyrella spyrella merged commit 8af2d18 into League-of-Fabulous-Developers:dev Aug 19, 2024
@MattByName
Copy link
Contributor Author

I just noticed I didn't update the uuid inside the new item json, and only put it in the filename. I'm not sure what the best way to generate an id is, I just made one in foundry by creating a copy of one of the other items. Will that cause problems?

@spyrella
Copy link
Collaborator

No worries, i just generated a new id and edited the id in the json.

@Christopher-R-Perkins
Copy link

I thought the idea was that you would have the twin shields item only replace one of the shields ands still have the other equipped on your offhand.

@MattByName MattByName deleted the dev branch August 19, 2024 14:28
@MattByName MattByName restored the dev branch August 19, 2024 14:28
@MattByName MattByName deleted the dev branch August 19, 2024 14:28
@MattByName MattByName restored the dev branch August 19, 2024 15:18
@fultimator-official
Copy link

I thought the idea was that you would have the twin shields item only replace one of the shields ands still have the other equipped on your offhand.

I guess the issue with this is that twin shield counts as a two handed weapon so it’ll take up both main and off hand. I’m holding off doing anything with shields until the equipment system is overhauled, where equipment data is stored in the actor instead of items. From there we could work on equipment validation.

Maybe adding a checkbox that’ll allow you to equip two handed weapons in one slot. So you could equip another shield and gain their benefits.

@spyrella
Copy link
Collaborator

spyrella commented Aug 23, 2024

To update everyone, in V2.4.0, with the new implementation of EquipmentHandlerV2, the other twin shields wouldn't be necessary anymore since you can now equip two shields and also equip the twin shield item into a "phantom slot".
image

Thanks for the help, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants