[GridLayer] redraw tiles properly after changing maxNativeZoom #6443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
changed the title
cherniavskii
changed the title
|
Btw, running CI tests in Firefox really helped here - at some point tests passed in PhantomJS, but failed in Firefox |
|
I guess I'll wait for one more approval for this PR just to make sure it will not break anything |
|
Happy new year! Here is the updated Plunker showing the PR in action: Would probably benefit from a test. |
|
@ghybs Happy New Year to you too! Thanks for looking into this. |
johnd0e
reviewed
Apr 18, 2020
johnd0e
force-pushed
the
cherniavskii-patch-1
branch
from
ea7c1c4 to
3a0980c
Compare
johnd0e
approved these changes
Jul 7, 2020
|
@mourner @IvanSanchez this would be a easy thing to review & merge |
mourner
approved these changes
Nov 26, 2021
mourner
added a commit
to johnd0e/Leaflet
that referenced
this pull request
Dec 2, 2021
* master: (180 commits) Create leaflet-coloricon.md (Leaflet#7812) Update zoom buttons documentation text (Leaflet#7815) Lint examples (Leaflet#7827) revert linting examples (accidentally pushed to master) add linting to examples (WIP) Tests: simplify .near and .nearLatlng usage (Leaflet#7820) Simplifiy examples (Leaflet#7816) [GridLayer] redraw tiles properly after changing maxNativeZoom (Leaflet#6443) New TapHold handler instead of legacy Tap (Leaflet#7026) Fix Leaflet#7439 for mousemove (Leaflet#7809) Improve panInside documentation (Leaflet#7397) ignore built docs when running eslint Update Renderer documentation to clarify tolerance option Canvas only (Leaflet#7515) Add documentation for Event Listens Propagate argument. Fixes Leaflet#6912 (Leaflet#7103) Add aria-hidden to the +/- characters of zoom controls (Leaflet#7795) Fix Popup keepInView if the map needs to panned over a long distance (Leaflet#7792) Accessibility popup close button (Leaflet#7794) Add keepInView test (Leaflet#7790) Add fallbacks to font-size (Leaflet#7800) Remove leaflet-include.js (Leaflet#7776) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blind attempt to fix #6438
Case 1: set
maxNativeZoomhigher than current zoom and redraw:Before / After:
Case 2: Zoom in, set
maxNativeZoomhigher than initial zoom and redraw:Before / After:
Playground link:
https://plnkr.co/edit/ORkCquW4i2kIYLyOmcjl?p=preview