feat: UX improvement #258
Open
feat: UX improvement #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
commented
Jan 30, 2025
This was referenced Jan 31, 2025
supernovahs
reviewed
Feb 5, 2025
| .process_new_signature(task_index, task_response_digest, signature, operator_id) | ||
| .await?; | ||
| info!("processed signature for index {:?}", task_index); | ||
| let quorum_reached = { |
There was a problem hiding this comment.
this assumed that 2 signatures are needed to process .
there's a better way in dev branch here
https://github.com/Layr-Labs/incredible-squaring-avs-rs/blob/b953a8127b604d91175d71e7c2b47ad4023f7e77/crates/aggregator/src/lib.rs#L320-L395
it handles all cases using total stake and quorum threshold percentage. Its hardcoded rn there with 4800 (40% of 12000(total stake))
There was a problem hiding this comment.
Yes. However, I was thinking of just waiting for a signature aggregate to be returned by the BLS aggregation service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
What Changed?
This PR introduces two new crates to the SDK:
eigen-aggregatorandeigen-operator, with a higher-level interface than the other crates.Reviewer Checklist
changelog-Xlabels (if applies)