feat: slashing release #311

stevennevins · 2024-10-17T19:24:34Z

No description provided.

* chore: update mock contracts with latest interfaces

* chore: checkout migration branch * feat: implement migration function * chore: update to release branch * feat: operator set creation for each quorum number * feat: migration with merge sorted array of operators and their quorums * feat: operator set migration working * chore: revert change from testing * chore: revert change from testing * chore: remove extra logging and commented out asserts * chore: remove unused file * fix: remove console logs * refactor: to view functions * chore: nit and remove unneeded function * fix: remove duplication of looping for all the operators * chore: remove comment * feat: allow migrating in two transactions * feat: finalization of migration * chore: use string errors and fix migration issues * chore: rename * feat: use library for merge sort * test: fuzz view function

* chore: checkout migration branch * feat: implement migration function * chore: update to release branch * feat: operator set creation for each quorum number * feat: migration with merge sorted array of operators and their quorums * feat: operator set migration working * chore: revert change from testing * chore: revert change from testing * chore: remove extra logging and commented out asserts * chore: remove unused file * fix: remove console logs * feat: create quorum post operator set migration * test(wip): create quorum test adds new operator set * test: migration create quorum * refactor: to view functions * chore: nit and remove unneeded function * fix: remove duplication of looping for all the operators * chore: remove comment * feat: allow migrating in two transactions * feat: finalization of migration * chore: use string errors and fix migration issues * chore: rename * feat: use library for merge sort * test: fuzz view function * fix: updates from merge * chore: use interface

* chore: update to latest eigenlayer-contracts feat/operator-set-release * chore: add method to mock

* feat: update stakes handle direct deregistration on AVSDirectory * test: update stake for quorum if operator directly unregistered from the AVSDirectory * chore: simplify setup * chore: simplify setup * chore: make service manager immutable on stakeRegistry

* feat: register and deregister to operator sets * fix: bytecode wrangling * chore: shorter errors to reduce bytecode * test: register after migration * chore: remove stale todos * chore: add back commented line * chore: remain consistent with m2 events * fix: side effect of merge from _deregister function * fix: bytecode massaging * chore: rename for clarity * chore: remove comments and whitespace * docs: add natspec to the library

* feat: upgrade and test pre prod upgrade and migration * fix: add param introduced in merge

* chore: bump to slashing branch * chore: bump compiler version * fix: dep interface changes * fix: compiler errors from interface changes and type changes * fix: compiler errors * chore: bump dependencies * chore: bump core dependency and resolve issues * chore: bump core dependency and fix compiler errors * feat: integrate AllocationManager * feat: add a slashing permission to the service manager * chore: remove unneeded casting * feat: implement a slasher permission and forward call to AllocationManager * feat: add simiple slasher starting point * chore: bump slashing magnitudes * chore: bump core slashing-magnitudes branch

* chore: bump to slashing branch * chore: bump compiler version * fix: dep interface changes * fix: compiler errors from interface changes and type changes * fix: compiler errors * chore: bump dependencies * chore: bump core dependency and resolve issues * chore: bump core dependency and fix compiler errors * feat: integrate AllocationManager * feat: add a slashing permission to the service manager * chore: remove unneeded casting * feat: implement a slasher permission and forward call to AllocationManager * feat: add simiple slasher starting point * feat: slashers * chore: change around slashed event * fix: call dm * feat: add proposal mechanism for updating slasher * fix: set to completed instead of delete * chore: use struct instead of params directly * chore: clean up params more * chore: simplify and organize files * chore: cleanup logic and couple event with internal func * fix: pass correct params * chore: organize and add interface * chore: nits * chore: cleanup more nits * fix: storage gap * chore: nits refactor * chore: go back to fulfill being onlySlasher * test: fixes from core updates * fix: use delegated stake per operator set instead of per AVS * fix: update to 14 days * feat: configurable lookahead and stake type

src/ServiceManagerBaseStorage.sol

src/StakeRegistry.sol

* feat: remove both option * chore: remove unused test util contracts * chore: remove diff

#317) * feat: remove both option * feat: total delegated stake and total slashable stake per quorum config * test: resolve some breaking changes to tests * chore: move stake type to file level definition * chore: refactor loop * test: add unit test for slashble stake quorum init * test: assert on state and event * test: delegated stake quorum and assertions

supernovahs · 2024-12-04T10:30:48Z

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from contract TransparentUpgradeableProxy to contract ITransparentUpgradeableProxy requested.
   --> lib/eigenlayer-middleware/test/utils/MockAVSDeployer.sol:310:17:
    |
310 |                 TransparentUpgradeableProxy(payable(address(registryCoordinator))),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Error: Compilation failed

getitng this while compiling my contracts in IS with this as submodule

test/mocks/ECDSAServiceManagerMock.sol

src/StakeRegistry.sol

src/RegistryCoordinator.sol

src/slashers/VetoableSlasher.sol

* refactor: uam * feat: add uam interfaces * fix: lookahead period to blocks * fix: tests * chore: storage report

* feat: ci forge coverage * fix: ci

* feat: ci forge fmt * chore: forge fmt

* feat: add register with churn type * fix: tests for encoded registration type * feat: add ejector support for operator sets * refactor: handle operator set dereg * fix: dereg on churn from ALM if needed

* refactor: slashing registry coordinator refactor: registry coordinator refactor: remove sm calls fix: tests wip * fix: integration tests * refactor: internal functions * fix: remove unused block * fix: comment out test for now * build: fmt check run only on src contracts * fix: call SM only based on m2 quorums (#369) * feat: update enableOperatorSets flow (#367) * feat: update enableOperatorSets flow * fix: dereg op check * chore: renamed m2 quorums * fix: msg.sender -> operator * chore: forge fmt * fix: tests --------- Co-authored-by: Yash Patil <[email protected]>

* refactor: natspec + interfaces refactor: natspec + interfaces refactor: natspec + interfaces docs: `RegistryCoordinator` natspec chore: forge fmt refactor: named mapping params docs: natspec `BLSApkRegistry` docs: natspec `BLSApkRegistry` docs: natspec `BLSApkRegistry` refactor: interface structure refactor: separate `BLSSignatureChecker` storage refactor: rename -> `IECDSAStakeRegistry` docs: natspec docs: natspec `ECDSAStakeRegistry` docs: natspec `EjectionManager` + separate storage docs: natspec docs: natspec `IndexRegistry` refactor: remove `IRegistry` chore: forge fmt chore: make storage-report docs: natspec refactor: remove `ISocketUpdater` refactor: use refactor: remove todo refactor: `///` -> `/**` refactor: improve comment refactor: rename var refactor: improve comment * fix: compiling - tests failing * refactor: test passing **mostly** * refactor: add missing gap * refactor: natspec * fix: test - state changes moved out of internal * chore: forge fmt * refactor: reorganize errors * refactor: remove override * refactor: note avsd * Yash/natspec - address comments (#372) * feat: natpsec with inheritance * feat: storage * chore: format * chore: fmt * chore: format * fix: test * fix: test --------- Co-authored-by: Michael Sun <[email protected]> Co-authored-by: Yash Patil <[email protected]>

ypatil12

LGTM

gpsanant · 2025-02-01T06:36:12Z

src/OperatorStateRetriever.sol

        IStakeRegistry stakeRegistry = registryCoordinator.stakeRegistry();
        IIndexRegistry indexRegistry = registryCoordinator.indexRegistry();
        IBLSApkRegistry blsApkRegistry = registryCoordinator.blsApkRegistry();

        Operator[][] memory operators = new Operator[][](quorumNumbers.length);
        for (uint256 i = 0; i < quorumNumbers.length; i++) {
            uint8 quorumNumber = uint8(quorumNumbers[i]);
-            bytes32[] memory operatorIds = indexRegistry.getOperatorListAtBlockNumber(quorumNumber, blockNumber);
+            bytes32[] memory operatorIds =
+                indexRegistry.getOperatorListAtBlockNumber(quorumNumber, blockNumber);


use the ALM's function for operatorSets

gpsanant · 2025-02-01T06:40:31Z

src/StakeRegistry.sol

+     * @param quorumNumber The quorum number to set the look ahead period for
+     * @param _lookAheadBlocks The number of blocks to look ahead when checking shares
+     */
+    function _setLookAheadPeriod(uint8 quorumNumber, uint32 _lookAheadBlocks) internal {


doesn't check that the quorum is for slashable stake

gpsanant · 2025-02-01T06:42:05Z

src/StakeRegistry.sol

     */
+
+    /// @inheritdoc IStakeRegistry
+    function isOperatorSetQuorum(


seems like this should be an external function on the registryCoordinator

gpsanant · 2025-02-01T06:43:56Z

src/StakeRegistry.sol

+
+        if (stakeTypePerQuorum[quorumNumber] == IStakeRegistryTypes.StakeType.TOTAL_SLASHABLE) {
+            strategyShares = _getSlashableStakePerStrategy(quorumNumber, operator);
+            for (uint256 i = 0; i < stratsLength; i++) {


move this loop outside the conditional, it is duplicated

gpsanant · 2025-02-01T06:46:55Z

src/StakeRegistry.sol

+    ) internal view returns (uint256[] memory) {
+        address[] memory operators = new address[](1);
+        operators[0] = operator;
+        uint32 beforeTimestamp =


beforeBlock

gpsanant and others added 19 commits July 17, 2024 11:42

Update LICENSE (#285)

7d49b51

chore: upgrade core to target operator set release

163f4c3

Merge branch 'dev' into feat/operate-set-release-branch

ad64a45

chore: update mock contracts with latest interfaces (#293)

b7f4903

* chore: update mock contracts with latest interfaces

chore: bump to latest operator set release commits

d991827

chore: fixes for depedency bump

4966813

chore: bump operator set release dependency in core

e5b2688

chore: updates from dependency bump

ec2fdf3

feat: add natspec

12eda5d

docs: add natspec

788cd09

feat: add checks operator was registered for quorums when migrating

d64f4af

fix: resolve code size issue in RegistryCoordinator

a92d51a

chore: update to latest core (#299)

32148de

* chore: update to latest eigenlayer-contracts feat/operator-set-release * chore: add method to mock

merge dev

3e4cb2b

feat(op sets): upgrade and migrate script (#303)

e0a79f1

* feat: upgrade and test pre prod upgrade and migration * fix: add param introduced in merge

stevennevins changed the title ~~Feat/slashing release branch~~ feat: slashing release Oct 17, 2024

stevennevins added 2 commits October 17, 2024 17:05

wadealexc reviewed Nov 8, 2024

View reviewed changes

src/ServiceManagerBaseStorage.sol Outdated Show resolved Hide resolved

wadealexc reviewed Nov 8, 2024

View reviewed changes

src/StakeRegistry.sol Outdated Show resolved Hide resolved

stevennevins and others added 4 commits November 18, 2024 13:52

chore: remove unused test util contracts (#319)

145bdaf

* feat: remove both option * chore: remove unused test util contracts * chore: remove diff

feat: remove both option

9a975df

fix: storage gap remove one slot (#320)

fa04f06

supernovahs reviewed Dec 4, 2024

View reviewed changes

test/mocks/ECDSAServiceManagerMock.sol Outdated Show resolved Hide resolved

8sunyuan reviewed Jan 10, 2025

View reviewed changes

src/StakeRegistry.sol Outdated Show resolved Hide resolved

stevennevins added 2 commits January 10, 2025 16:38

chore: review remove setStakeType

34456b3

fix: wire up stake registry to call add and rm strategies for op set

2246b7d

8sunyuan reviewed Jan 13, 2025

View reviewed changes

src/RegistryCoordinator.sol Outdated Show resolved Hide resolved

8sunyuan reviewed Jan 13, 2025

View reviewed changes

src/RegistryCoordinator.sol Outdated Show resolved Hide resolved

ypatil12 reviewed Jan 13, 2025

View reviewed changes

src/RegistryCoordinator.sol Outdated Show resolved Hide resolved

8sunyuan reviewed Jan 13, 2025

View reviewed changes

src/slashers/VetoableSlasher.sol Outdated Show resolved Hide resolved

8sunyuan and others added 5 commits January 17, 2025 15:11

refactor: slashing UAM (#357)

3b8d801

* refactor: uam * feat: add uam interfaces * fix: lookahead period to blocks * fix: tests * chore: storage report

feat: ci forge coverage (#349)

3654478

* feat: ci forge coverage * fix: ci

feat: add forge fmt to ci (#363)

d2bfd57

* feat: ci forge fmt * chore: forge fmt

feat: add register with churn type (#360)

7e8aeff

* feat: add register with churn type * fix: tests for encoded registration type * feat: add ejector support for operator sets * refactor: handle operator set dereg * fix: dereg on churn from ALM if needed

MegaRedHand mentioned this pull request Jan 27, 2025

feat: update middleware submodule to v1.0.3-testnet-slashing release Layr-Labs/eigensdk-go#478

Merged

3 tasks

8sunyuan and others added 6 commits January 27, 2025 18:12

fix: commented out view (#373)

4954139

chore: resolve merge conflicts

18e8d80

chore: forge fmt

ce65f85

feat: storage gap on socket registry

c558283

chore: remove unused storage; update bindings

650024a

stevennevins marked this pull request as ready for review January 28, 2025 00:17

chore: nuke storage report script for now on ci

2015201

8sunyuan approved these changes Jan 28, 2025

View reviewed changes

ypatil12 approved these changes Jan 28, 2025

View reviewed changes

stevennevins merged commit 11b0061 into dev Jan 28, 2025
5 checks passed

stevennevins deleted the feat/slashing-release-branch branch January 28, 2025 00:25

gpsanant reviewed Feb 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: slashing release #311

feat: slashing release #311

stevennevins commented Oct 17, 2024

supernovahs commented Dec 4, 2024

ypatil12 left a comment

gpsanant Feb 1, 2025

gpsanant Feb 1, 2025

gpsanant Feb 1, 2025

gpsanant Feb 1, 2025

gpsanant Feb 1, 2025

feat: slashing release #311

feat: slashing release #311

Conversation

stevennevins commented Oct 17, 2024

supernovahs commented Dec 4, 2024

ypatil12 left a comment

Choose a reason for hiding this comment

gpsanant Feb 1, 2025

Choose a reason for hiding this comment

gpsanant Feb 1, 2025

Choose a reason for hiding this comment

gpsanant Feb 1, 2025

Choose a reason for hiding this comment

gpsanant Feb 1, 2025

Choose a reason for hiding this comment

gpsanant Feb 1, 2025

Choose a reason for hiding this comment