Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail on storage diff #759

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix: fail on storage diff #759

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15b08b5
fix: fail on storage diff
0xClandestine Sep 17, 2024
d62ebe1
test(ci): add variable to see if ci fails
0xClandestine Sep 17, 2024
87c0974
test(ci): remove variable
0xClandestine Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/storage-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: recursive

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
Expand All @@ -34,6 +35,9 @@ jobs:

- name: Compare outputs
run: |
if ! diff --unified pr target; then
echo "::warning::Differences found between PR and target branch storage layouts"
fi
if diff --unified pr target; then
echo "No differences found"
else
echo "::error::Differences found between PR and target branch storage layouts"
exit 1
fi
2 changes: 2 additions & 0 deletions src/contracts/core/AVSDirectoryStorage.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
*/
bytes32 internal _DOMAIN_SEPARATOR;

uint256 public _TEST_CI;
Fixed Show fixed Hide fixed

/// @notice Mapping: AVS => operator => enum of operator status to the AVS
mapping(address => mapping(address => OperatorAVSRegistrationStatus)) public avsOperatorStatus;

Expand Down
Loading