Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: parallelize foundry workflows #1094

Merged
merged 8 commits into from
Feb 13, 2025
Merged

perf: parallelize foundry workflows #1094

merged 8 commits into from
Feb 13, 2025

Conversation

bowenli86
Copy link
Member

@bowenli86 bowenli86 commented Feb 13, 2025

Motivation:

Since Foundry unit, integration, and fork tests currently run sequentially, the total runtime is the sum of all tests — roughly 25–26 minutes.

See yourself here.

Modifications:

  • Parallelized unit, integration, and fork tests to significantly speed up CI.
  • Fixed flaky tests.

Result:

By running all three test suites in parallel, we reduced the total runtime to 6 minutes, achieving a 4× speedup!

@bowenli86
Copy link
Member Author

synced with @0xClandestine and have migrated to a new PR in order to target dev branch

@ypatil12
Copy link
Collaborator

ypatil12 commented Feb 13, 2025

The CI now runs both parallelized and non-parallelized tests, we should do one

Copy link
Member

@0xClandestine 0xClandestine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just need to reorganize a bit.

@bowenli86
Copy link
Member Author

image

looks good

i've given it a larger runner with 16cpu, seems have brought down integration tests further down from 12min to 6min, so the total speedup is 4X now with 24min -> 6min

0xClandestine
0xClandestine previously approved these changes Feb 13, 2025
@0xClandestine 0xClandestine changed the title feat: parallelize all test suites to expedite CI run time perf: parallelize foundry workflows Feb 13, 2025
0xClandestine
0xClandestine previously approved these changes Feb 13, 2025
@0xClandestine 0xClandestine merged commit b6ba879 into dev Feb 13, 2025
9 checks passed
@0xClandestine 0xClandestine deleted the feat/fasttest branch February 13, 2025 22:31
ypatil12 pushed a commit that referenced this pull request Feb 19, 2025
**Motivation:**

Since Foundry unit, integration, and fork tests currently run
sequentially, the total runtime is the sum of all tests — roughly
**25–26 minutes**.

See yourself
[here](https://github.com/Layr-Labs/eigenlayer-contracts/actions/runs/13208807194/job/36878141793?pr=1025).

**Modifications:**

- Parallelized unit, integration, and fork tests to significantly speed
up CI.
- Fixed flaky tests.

**Result:**

By running all three test suites in parallel, we reduced the total
runtime to **6 minutes**, achieving a **4× speedup**!

---------

Co-authored-by: clandestine.eth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants