Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old release scripts #1066

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

0xClandestine
Copy link
Member

Motivation:

After speaking with @jbrower95 I learned the zeus release scripts are designed to be deletable.

Modifications:

  • Removed old release scripts in script/releases.

Result:

Modifying code no longer creates issues because of old scripts we're no longer using.

@0xClandestine 0xClandestine force-pushed the chore/remove-old-deployers branch from f3b72ba to e2f261a Compare February 4, 2025 15:57
@0xClandestine 0xClandestine force-pushed the chore/remove-old-deployers branch from e2f261a to 2fa5c25 Compare February 4, 2025 15:59
@jbrower95 jbrower95 self-requested a review February 4, 2025 16:27
Copy link
Contributor

@jbrower95 jbrower95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zeus scripts are designed to be deleted. deployers should check out the pinned commit on the upgrade when applying the upgrade.

totally cool to remove these once they are no longer needed.

@0xClandestine 0xClandestine merged commit 73ccd72 into dev Feb 4, 2025
6 of 7 checks passed
@0xClandestine 0xClandestine deleted the chore/remove-old-deployers branch February 4, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants