Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Update template dependencies for webpack 3 (was: App template: Update to webpack 3) #17

Closed
alex3683 opened this issue Jun 20, 2017 · 7 comments

Comments

@alex3683
Copy link
Member

alex3683 commented Jun 20, 2017

Currently the webpack-dev-server is still not webpack 2 aware. As soon as this is no longer an issue, we should update.
See webpack/webpack-dev-server#932

@jpommerening
Copy link
Member

webpack/webpack-dev-server#946 (comment)

@x1B
Copy link
Member

x1B commented Jul 7, 2017

After giving it a quick spin against a LaxarJS2/Vue.js app, it definitely feels faster now. HMR also still working, so I guess this is go.

@alex3683
Copy link
Member Author

Are we treating this as a breaking change? (See LaxarJS/laxar#470 (comment))

@x1B
Copy link
Member

x1B commented Jul 11, 2017

@alex3683 I think, for a change to the generator to be breaking, it would mean that a new version can no longer generate widgets/activities for an application created with an older version. So this would not be breaking.

@alex3683
Copy link
Member Author

@x1B Okay, that is in accordance to what @jpommerening and me discussed yesterday.

@alex3683 alex3683 changed the title App template: Update to webpack 3 Update template dependencies (was: App template: Update to webpack 3) Jul 11, 2017
@alex3683
Copy link
Member Author

Changed the title, since more plugins and other dependencies needed to be lifted to be compatible with webpack 3.

@alex3683 alex3683 changed the title Update template dependencies (was: App template: Update to webpack 3) Update template dependencies for webpack 3 (was: App template: Update to webpack 3) Jul 11, 2017
@alex3683
Copy link
Member Author

Implemented on master (v2.1.0).

Upgrade Information

Since webpack 3 was announced to be non-breaking, we assume that there will be no problems with this change. Our tests showed none.
By default the new ModuleConcatenationPlugin for Scope Hoisting is loaded. Feel free to remove it in the generated app, if you don't want it.

@alex3683 alex3683 self-assigned this Jul 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants