-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a11y plugin #17
Add a11y plugin #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 🎉 🎉
We may want to try this on an existing project to see if there are any rules that we need to tweak before publicizing the migration.
@chawes13 good call. Would you be willing to try out the recommended rules on Artlook? |
Yeah, definitely. Should I add the plugin there directly or should we merge this and not publicize it until after a few weeks of tinkering? |
I'd go for the former, less merging and versions to deal with 😁 |
You got it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we're holding off on merging until we have piloted this and converged on the ruleset to include
@chawes13 oof! were any of them auto-fixes? Did any seem extraneous or were they all legit? |
@dpikt unfortunately I haven't looked at fixing the issues yet since the map details page scope exploded. I'll probably have feedback to report in the next 2 weeks |
Sounds good, I'll add an assignment for the follow-up. |
Closing in favor of |
Resolves #13