Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a11y plugin #17

Closed
wants to merge 1 commit into from
Closed

Add a11y plugin #17

wants to merge 1 commit into from

Conversation

dpikt
Copy link
Contributor

@dpikt dpikt commented Jun 25, 2019

Resolves #13

@dpikt dpikt requested a review from chawes13 June 25, 2019 18:41
Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 🎉 🎉

We may want to try this on an existing project to see if there are any rules that we need to tweak before publicizing the migration.

@chawes13 chawes13 removed their assignment Jun 26, 2019
@dpikt
Copy link
Contributor Author

dpikt commented Jun 26, 2019

@chawes13 good call. Would you be willing to try out the recommended rules on Artlook?

@chawes13
Copy link
Contributor

Yeah, definitely. Should I add the plugin there directly or should we merge this and not publicize it until after a few weeks of tinkering?

@dpikt
Copy link
Contributor Author

dpikt commented Jun 26, 2019

I'd go for the former, less merging and versions to deal with 😁

@chawes13
Copy link
Contributor

You got it!

Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we're holding off on merging until we have piloted this and converged on the ruleset to include

@chawes13
Copy link
Contributor

chawes13 commented Jul 1, 2019

🙈
image

@dpikt
Copy link
Contributor Author

dpikt commented Jul 9, 2019

@chawes13 oof! were any of them auto-fixes? Did any seem extraneous or were they all legit?

@chawes13
Copy link
Contributor

chawes13 commented Jul 9, 2019

@dpikt unfortunately I haven't looked at fixing the issues yet since the map details page scope exploded. I'll probably have feedback to report in the next 2 weeks

@dpikt
Copy link
Contributor Author

dpikt commented Jul 9, 2019

Sounds good, I'll add an assignment for the follow-up.

@chawes13
Copy link
Contributor

chawes13 commented Apr 3, 2023

Closing in favor of v3 updates

@chawes13 chawes13 closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSX a11y plugin
2 participants