Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fallback for removal of callback_url in omniauth-oauth2 dependency. #2

Merged
merged 1 commit into from
Feb 6, 2017
Merged

Create fallback for removal of callback_url in omniauth-oauth2 dependency. #2

merged 1 commit into from
Feb 6, 2017

Conversation

enthusiastick
Copy link
Contributor

As described here, this is (believe it or not!) the simplest fix.

@dtnorris
Copy link
Contributor

dtnorris commented Feb 6, 2017

@dpickett you wrote this originally right? This looks fine to me, but I just wanted to check if this raises any concerns for you?

@enthusiastick does it make sense to add any tests for this method?

@dtnorris
Copy link
Contributor

dtnorris commented Feb 6, 2017

@enthusiastick
If this is blocking you I’d just merge this. If we think of an issue down the line we can push a fix then IMHO.

@enthusiastick enthusiastick merged commit 816162a into master Feb 6, 2017
@dtnorris dtnorris deleted the explicit-callback-url-method branch February 7, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtnorris dtnorris dtnorris approved these changes

Assignees

@dpickett dpickett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enthusiastick @dtnorris @dpickett