fix(pluginutils): keep for(const..) out of scope (rollup#151)

* fix(pluginutils): createFilter windows regression * chore: diagnose windows * fix(pluginutils): keep for(const..) out of scope * chore: clean up comments * chore: revert github workflow
LarsDenBakker · Sep 12, 2020 · 26f984b · 26f984b
1 parent 12c937f
commit 26f984b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/pluginutils/src/attachScopes.ts b/packages/pluginutils/src/attachScopes.ts
@@ -71,10 +71,13 @@ const attachScopes: AttachScopes = function attachScopes(ast, propertyName = 'sc
       if (node.type === 'VariableDeclaration') {
         const { kind } = node;
         const isBlockDeclaration = blockDeclarations[kind];
-
-        node.declarations.forEach((declaration: Node) => {
-          scope.addDeclaration(declaration, isBlockDeclaration, true);
-        });
+        // don't add const/let declarations in the body of a for loop #113
+        const parentType = parent ? parent.type : '';
+        if (!(isBlockDeclaration && /ForOfStatement/.test(parentType))) {
+          node.declarations.forEach((declaration: Node) => {
+            scope.addDeclaration(declaration, isBlockDeclaration, true);
+          });
+        }
       }
 
       let newScope: AttachedScope | undefined;

diff --git a/packages/pluginutils/src/createFilter.ts b/packages/pluginutils/src/createFilter.ts
@@ -37,6 +37,7 @@ const createFilter: CreateFilter = function createFilter(include?, exclude?, opt
             const pattern = getMatcherString(id, resolutionBase);
             const fn = mm.matcher(pattern, { dot: true });
             const result = fn(what);
+
             return result;
           }
         };