Improve create #19
Closed
Improve create #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxpm
added
Priority: MUST
and removed
enhancement
Merged
|
Hey @adriallongarriu thanks for the heads up and for the PR. I think only disabling the fields won't necessary prevent the updates, in that regard I moved your PR to a new branch to add my own fixes on top of yours. I will be closing this PR and merging the #22 that also has your contributions there. Thanks 🙏 |
pxpm
added a commit
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug fields
groupandkeyare always disabled ignoring the config option'create' => true,Plus add validation required to group and key to prevent error if left empty.