Fix #4352 - ListOperation modal no longer showing when ellipsis is clicked #4377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4352
WHY
BEFORE - What was wrong? What was happening before this PR?
Ellipsis with row details were not working.
AFTER - What is happening after this PR?
Details are working again with the modal 🙌
HOW
How did you achieve that, in technical terms?
There was a conflict with a
data-responsive
attribute on table 🤦♂️By changing
data-responsive
todata-responsive-table
the conflict is solved.Is it a breaking change?
No.
The big issue here is that people need to republish the assets to get everything working properly.
The good news is, this fix will make the modal work for everybody with no publish, the publish will fix a minor issue, the changes on the CSS just set some stuff for non responsive tables (few people use).
That said, the worst case here is devs who use non responsive table, will now get the strange rows in the beginning and end of the table, that were there in the v5 lunch (fixed by that PR in 5.0.14);
Any way, tested everything again with all the variables, let's hope this is done for good, with no issues now 🙌