PHP 8.4 support

.gitattributes

@@ -10,4 +10,5 @@
 /tests              export-ignore
 /.editorconfig      export-ignore
 /.styleci.yml       export-ignore
-/composer.lock      export-ignore
+/composer.lock      export-ignore
+/phpstan.neon       export-ignore

.github/workflows/php.yml

@@ -53,6 +53,7 @@ jobs:
           - 8.1
           - 8.2
           - 8.3
+          - 8.4
         laravel-constraint:
           - 10.*
           - 11.*

composer.json

@@ -46,7 +46,8 @@
     },
     "require-dev": {
         "ext-sodium": "*",
-        "orchestra/testbench": "8.*|9.*"
+        "orchestra/testbench": "8.*|9.*",
+        "livewire/livewire": "3.*"
     },
     "suggest": {
         "paragonie/sodium_compat": "To enable EdDSA 25519 keys from authenticators, if `ext-sodium` is unavailable."

phpstan.neon

@@ -0,0 +1,3 @@
+parameters:
+    ignoreErrors:
+        - '#Trait Laragear\\WebAuthn\\WebAuthnAuthentication is used zero times and is not analysed\.#'

src/Assertion/Validator/AssertionValidation.php

@@ -38,7 +38,7 @@ public function __construct(
     /**
      * Create a new Assertion Validation instance from a WebAuthn request data.
      */
-    public static function fromRequest(Request $request = null): static
+    public static function fromRequest(?Request $request = null): static
     {
         // @phpstan-ignore-next-line
         return new static(new JsonTransport(($request ?? app('request'))->only(static::REQUEST_KEYS)));

src/Attestation/Validator/AttestationValidation.php

@@ -38,7 +38,7 @@ public function __construct(
     /**
      * Create a new Attestation Creation instance from a request and a user.
      */
-    public static function fromRequest(Request $request = null, WebAuthnAuthenticatable $user = null): static
+    public static function fromRequest(?Request $request = null, ?WebAuthnAuthenticatable $user = null): static
     {
         // @phpstan-ignore-next-line
         return new static($user, new JsonTransport(($request ?? app('request'))->only(static::REQUEST_KEYS)));

src/ByteBuffer.php

@@ -144,7 +144,7 @@ public function hashNotEqual(self|string $buffer): bool
     /**
      * Returns a certain portion of these bytes.
      */
-    public function getBytes(int $offset = 0, int $length = null): string
+    public function getBytes(int $offset = 0, ?int $length = null): string
     {
         $length ??= $this->dataLength;
 

src/Http/Requests/AssertedRequest.php

@@ -50,10 +50,10 @@ public function hasRemember(): bool
      * @return \Laragear\WebAuthn\Contracts\WebAuthnAuthenticatable|\Illuminate\Contracts\Auth\Authenticatable|null
      */
     public function login(
-        string $guard = null,
-        bool $remember = null,
+        ?string $guard = null,
+        ?bool $remember = null,
         bool $destroySession = false,
-        callable|array $callbacks = null
+        callable|array|null $callbacks = null
     ): ?WebAuthnAuthenticatable {
         /** @var \Illuminate\Contracts\Auth\StatefulGuard $auth */
         $auth = auth()->guard($guard);

src/JsonTransport.php

@@ -38,7 +38,7 @@ public function set(string $key, mixed $value): void
     /**
      * Retrieves a value from the underlying JSON array.
      */
-    public function get(string $key, string|int $default = null): mixed
+    public function get(string $key, string|int|null $default = null): mixed
     {
         return Arr::get($this->json, $key, $default);
     }

src/Models/WebAuthnCredential.php

@@ -27,15 +27,15 @@
  * @method \Laragear\WebAuthn\Models\WebAuthnCredential firstOrNew(array $attributes = [], array $values = [])
  * @method \Laragear\WebAuthn\Models\WebAuthnCredential firstOrFail($columns = ['*'])
  * @method \Laragear\WebAuthn\Models\WebAuthnCredential firstOrCreate(array $attributes, array $values = [])
- * @method \Laragear\WebAuthn\Models\WebAuthnCredential firstOr($columns = ['*'], \Closure $callback = null)
+ * @method \Laragear\WebAuthn\Models\WebAuthnCredential firstOr($columns = ['*'], \Closure|null $callback = null)
  * @method \Laragear\WebAuthn\Models\WebAuthnCredential firstWhere($column, $operator = null, $value = null, $boolean = 'and')
  * @method \Laragear\WebAuthn\Models\WebAuthnCredential updateOrCreate(array $attributes, array $values = [])
  * @method \Laragear\WebAuthn\Models\WebAuthnCredential createOrFirst(array $attributes, array $values = [])
  * @method \Laragear\WebAuthn\Models\WebAuthnCredential sole($columns = ['*'])
  * @method \Laragear\WebAuthn\Models\WebAuthnCredential findOrNew($id, $columns = ['*'])
  * @method \Illuminate\Database\Eloquent\Collection<int, \static>|\static[]|\static|null find($id, $columns = ['*'])
  * @method \Illuminate\Database\Eloquent\Collection<int, \static>|\static[]|\static findOrFail($id, $columns = ['*'])
- * @method \Illuminate\Database\Eloquent\Collection<int, \static>|\static[]|\static findOr($id, $columns = ['*'], \Closure $callback = null)
+ * @method \Illuminate\Database\Eloquent\Collection<int, \static>|\static[]|\static findOr($id, $columns = ['*'], \Closure|null $callback = null)
  * @method \Illuminate\Database\Eloquent\Collection<int, \static>|\static[] findMany($id, $columns = ['*'])
  * @method \Illuminate\Database\Eloquent\Collection<int, \static>|\static[] fromQuery($query, $bindings = [])
  * @method \Illuminate\Support\LazyCollection<int, \static>|\static[] lazy(int $chunkSize = 1000)

src/WebAuthn.php

@@ -9,4 +9,13 @@
 class WebAuthn extends Http\Routes
 {
     //
+
+    public function something()
+    {
+        $some = ['foo', 'bar'];
+
+        foreach ($some as $key => $value) {
+            # code...
+        }
+    }
 }