Develop #7
Merged
Develop #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can now add custom events via a popup, and will be displayed in the timetable, and saved in localStorage
BottomNav would highlight the default tab(home) if a page was accessed directly via URL, instead of via the bottomNav. Fixed with using window.location.pathname
Replaced react state variables with normal js variables
Changed to FullCalendar from react-big-calendar, modified css to make the calendar fit better on a mobile screen
Moved themes to separate file, added a toggle in the side navbar Need to setup fonts and better colors, and possibly custom breakpoints
Theme was defaulting to dark on refresh, needed to store preferred theme in localStorage
Colors needed to be set with css variables to match the color theme provided by mui. Required some tinkering with the classes provided by FullCalendar
Added a loading component for incomplete API call, and an error message for API call error
Added padding to the individual cards Times were not being updated from 'loading' until you changed pages, issue with the useEffect dependencies, fixed.
Error message for when aims timetable was not synced was just a header, changed to a floating snackbar
Fixes the firebase warning that shows up in the console
Previously, app would flash the sign-in page briefly before continuing to homepage, changed to a circular loader
Adding date as a dependency in useEffect in Home.js caused an infinite loop, removed
Router needs basename for deployment on gh-pages sub-directory
Needed an extra meta tag for translucent status bar for ios pwa
Use a component for Login with proper styling and logo
This logo is seen on the PWA in the launch screen
|
Hi, Can we get a review on this PR please? I feel that periodically merging will help in bug-spotting/fixing easily compared to merging everything in one go. Thanks |
Manual update to segment start and end dates for the new semester, should move this to an API call in the future
aayush2710
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetic and styling changes, as well as a new timetable component that is more mobile friendly.