PathFinding and Vision #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Griffin9881
requested changes
Feb 12, 2025
| /** | ||
| * Base command for following a path | ||
| */ | ||
| public class DriveToWaypoint extends Command { |
There was a problem hiding this comment.
This should be named DriveToWaypointCommand
| } | ||
|
|
||
| @Override | ||
| public void initialize() { |
There was a problem hiding this comment.
is it possible you could do initialize, execute, and end in methods its really hard to read, maybe possibly a subsystem or in Auton so we could easily do it in our autons
…otics1038/2025RobotProject into pathfinding-main-merge
Griffin9881
previously approved these changes
Feb 12, 2025
|
We need to talk through how this works |
reediculous456
requested changes
Feb 14, 2025
reediculous456
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue Number
Closes #9
Closes #30
Comments
Merge pathfinding with main. Also adding vision.