Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bls key ownership check #138

Merged
merged 5 commits into from
Jul 13, 2024
Merged

feat: bls key ownership check #138

merged 5 commits into from
Jul 13, 2024

Conversation

cool-develope
Copy link
Contributor

Context

Closes: #137

Reviewers

@cool-develope cool-develope requested a review from a team July 11, 2024 00:26
@cool-develope cool-develope marked this pull request as draft July 11, 2024 00:26
@ChainDev931105 ChainDev931105 marked this pull request as ready for review July 12, 2024 17:48
cool-develope
cool-develope commented Jul 12, 2024
View reviewed changes
Copy link
Contributor Author

@cool-develope cool-develope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits, overll lgtm!

contracts/library/BLSKeyChecker.sol Outdated
mapping(address => mapping(bytes32 => bool)) operatorSalts;
}

// keccak256(abi.encode(uint256(keccak256("lagrange.storage")) - 1)) & ~bytes32(uint256(0xff))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// keccak256(abi.encode(uint256(keccak256("lagrange.storage")) - 1)) & ~bytes32(uint256(0xff))
// keccak256(abi.encode(uint256(keccak256("lagrange.blskeychecker.storage")) - 1)) & ~bytes32(uint256(0xff))

cool-develope
cool-develope commented Jul 13, 2024
View reviewed changes
Copy link
Contributor Author

@cool-develope cool-develope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@cool-develope cool-develope merged commit 37fe418 into develop Jul 13, 2024
3 checks passed
@cool-develope cool-develope deleted the bls/own_check branch July 13, 2024 16:51
ChainDev931105 added a commit that referenced this pull request Jul 30, 2024
@cool-develope @mastereng12
@ChainDev931105 @kashishshah
chore: mainnet v1-alpha (#143)
a5827f2 
* fix: clean up and add LICENSE (#78)

* clean up code

* clean build

* update license

* add audit reports

* fix committee.test.js (#79)

* revert epoch (#85)

* adjust operator count (#84)

* add workflow (#89)

* feat: update the BLS key and signer address (#88)

* allow to update the bls keys and signer address

* add tests

---------

Co-authored-by: Master Engineer <[email protected]>

* FEAT: Allow to update epoch period (#93)

* epoch_modifi draft

* update epoch formula

* fix reviewed issues

* fix reviewed issues

* fix naming of getEpochNumber

* epoch period modify unit test (#97)

* CHORE: Epoch period modify simulation (#98)

* simulation test for epoch period modify

* fix issue in redeloy script

* format

* fix: avoid to remove all bls pub keys (#102)

* fix the remove bls keys

* more tests

* Workflow with solhint (#101)

* solhint cli

* update solhint checkpoints

* Update contracts/protocol/VoteWeigher.sol

Co-authored-by: cool-developer <[email protected]>

---------

Co-authored-by: cool-developer <[email protected]>

* FEAT: eject operator (#105)

* feat eject operator

* fix reviewed errors

* strengthen test

* unsubscribe multiple operators

* FEAT: Deploy to Sepolia (#106)

* deploy sepolia

* testnet deploy script

Co-authored-by: cool-developer <[email protected]>

* add eigen sepolia addresses

---------

Co-authored-by: cool-developer <[email protected]>

* add fork test for rotate and revert (#107)

* Docker workflow (#109)

* push-docker yml

* add permission makefile

* push-docker-test

* install forge build

* remove test yml

* CHORE: Script for register chain (#108)

* add register chain script

* update epoch period

* update min/max weight

* update genersis block

* add basescript

* script eject op

* [FIX] Register operator sleep (#110)

* fix register-operator sleep

* remove test yml

* archive mode geth (#112)

* fix: geth docker cmd (#113)

* archive mode geth

* fix

* [Fix] audited issues (#115)

* fix audit issues

* add audit report

* Make epoch period flexible (#118)

* epoch period flexible

* test for epoch period flex

* add simulation test for flex period

* fix epoch period for prior blocks

* flow auto release (#127)

* add issue templates (#130)

* Script - Transfer ownership (#121)

* forge install: safe-smart-account

499b17ad0191b575fcadc5cb5b8e3faeae5391ae

* script transfer ownership

* Override for testnet committee - L1 Block Number (#123)

* testnet l1bias override

* fix annoying function naming

* feat: bls key ownership check (#138)

* bls key ownership check

* unit test & inherit checker

* optimize epoch number search

* fork test bls own check

* update storage hash

---------

Co-authored-by: ChainDev931105 <[email protected]>

* epic sequencer bls key (#140)

* Revert "epic sequencer bls key (#140)" (#141)

This reverts commit 1e57449.

* fix deploy-register (#142)

* fix

* [FIX] Audit Issues - Main (#149)

* Update README.md (#136)

* [FIX] script redeploy testnet (#144)

* fix script redeploy testnet

* fix get_updated_l1_block

* solc version 0.8.20, blsKeyChecker issue

* digest hash add version field

* hardhat solidity version update

---------

Co-authored-by: cool-developer <[email protected]>

---------

Co-authored-by: Master Engineer <[email protected]>
Co-authored-by: ChainDev <[email protected]>
Co-authored-by: Kashish Shah <[email protected]>
Co-authored-by: ChainDev931105 <[email protected]>
ChainDev931105 added a commit that referenced this pull request Aug 26, 2024
@ChainDev931105 @cool-develope
@mastereng12 @kashishshah
Merge Holesky to Mainnet (#158)
c7f666c 
* fix: clean up and add LICENSE (#78)

* clean up code

* clean build

* update license

* add audit reports

* fix committee.test.js (#79)

* revert epoch (#85)

* adjust operator count (#84)

* add workflow (#89)

* feat: update the BLS key and signer address (#88)

* allow to update the bls keys and signer address

* add tests

---------

Co-authored-by: Master Engineer <[email protected]>

* FEAT: Allow to update epoch period (#93)

* epoch_modifi draft

* update epoch formula

* fix reviewed issues

* fix reviewed issues

* fix naming of getEpochNumber

* epoch period modify unit test (#97)

* CHORE: Epoch period modify simulation (#98)

* simulation test for epoch period modify

* fix issue in redeloy script

* format

* fix: avoid to remove all bls pub keys (#102)

* fix the remove bls keys

* more tests

* Workflow with solhint (#101)

* solhint cli

* update solhint checkpoints

* Update contracts/protocol/VoteWeigher.sol

Co-authored-by: cool-developer <[email protected]>

---------

Co-authored-by: cool-developer <[email protected]>

* FEAT: eject operator (#105)

* feat eject operator

* fix reviewed errors

* strengthen test

* unsubscribe multiple operators

* FEAT: Deploy to Sepolia (#106)

* deploy sepolia

* testnet deploy script

Co-authored-by: cool-developer <[email protected]>

* add eigen sepolia addresses

---------

Co-authored-by: cool-developer <[email protected]>

* add fork test for rotate and revert (#107)

* Docker workflow (#109)

* push-docker yml

* add permission makefile

* push-docker-test

* install forge build

* remove test yml

* CHORE: Script for register chain (#108)

* add register chain script

* update epoch period

* update min/max weight

* update genersis block

* add basescript

* script eject op

* [FIX] Register operator sleep (#110)

* fix register-operator sleep

* remove test yml

* archive mode geth (#112)

* fix: geth docker cmd (#113)

* archive mode geth

* fix

* [Fix] audited issues (#115)

* fix audit issues

* add audit report

* Make epoch period flexible (#118)

* epoch period flexible

* test for epoch period flex

* add simulation test for flex period

* fix epoch period for prior blocks

* flow auto release (#127)

* add issue templates (#130)

* Script - Transfer ownership (#121)

* forge install: safe-smart-account

499b17ad0191b575fcadc5cb5b8e3faeae5391ae

* script transfer ownership

* Override for testnet committee - L1 Block Number (#123)

* testnet l1bias override

* fix annoying function naming

* feat: bls key ownership check (#138)

* bls key ownership check

* unit test & inherit checker

* optimize epoch number search

* fork test bls own check

* update storage hash

---------

Co-authored-by: ChainDev931105 <[email protected]>

* epic sequencer bls key (#140)

* Revert "epic sequencer bls key (#140)" (#141)

This reverts commit 1e57449.

* fix deploy-register (#142)

* update readme

---------

Co-authored-by: cool-developer <[email protected]>
Co-authored-by: Master Engineer <[email protected]>
Co-authored-by: Kashish Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChainDev931105 ChainDev931105 ChainDev931105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the Proof-of-Possession for the bls key and signer key registering
2 participants
@cool-develope @ChainDev931105