Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spherical colors #19

Conversation

alexmsrh
Copy link
Contributor

@alexmsrh alexmsrh commented Jun 7, 2023

I added two colour spaces: the barycentric colour space and spherical colour space. You can try the new features with the notebook demo_color_space.ipynb.
Main issues:

  • changing color space takes time because of "display" purposes (i.e., it is not related to the computation of the densities). This happens for both the barycentric and spherical color spaces. However, reducing the resolution significantly reduces the time.
  • The log-scale change in the barycentric color space is done manually (which is much slower than when done with the numpy argument norm). I could not link the selected scale directly into the ternary package used for barycentric plots. To fix this, one should probably look into ternary.colormapping.colorbar_hack
  • cannot draw on the barycentric plot. I did not try to pass a mask through the ternary objects, this could be investigated.
  • conversion from spherical density to spherical color space

added barycentric color space image
widget for color space selection
added log scale feature in color space demo notebook
@ClementCaporal ClementCaporal merged commit a688261 into LaboratoryOpticsBiosciences:new-channel-space Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants