Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTDT-3002] SDK updates for PDF connections #1951

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

kvilon
Copy link
Member

@kvilon kvilon commented Feb 11, 2025

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Test cases

  • Relationship with a source, but not source_ontology_name - should work correctly
  • Relationship with a source_ontology_name, but not source - should work correctly
  • Relationship with both source and source_ontology_name - throws an error, only one of them can be defined
  • Relationship without both source and source_ontology_name - throws an error, at least one of them should be defined
  • readonly field - can be True of False
  • Should support all 3 types of classifications (radio, checklist, text)
  • Should support both bounding boxes and text entities
  • Can import using python annotation classes
  • Can import using NDJSON

@kvilon kvilon requested a review from a team as a code owner February 11, 2025 14:55
Jmsa
Jmsa previously approved these changes Feb 11, 2025
Copy link

@Jmsa Jmsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PAT & LGTM

@kvilon
Copy link
Member Author

kvilon commented Feb 11, 2025

All tests pass locally (unit, integration, data).
Screenshot 2025-02-11 at 7 32 40 PM
Screenshot 2025-02-11 at 7 18 28 PM
Screenshot 2025-02-11 at 7 14 03 PM

@kvilon kvilon merged commit 4434c1d into develop Feb 12, 2025
22 of 26 checks passed
@kvilon kvilon deleted the stan/3002/source-schema branch February 12, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants