Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baryons as in van Daalen+ 2019 #1110

Merged
merged 13 commits into from
Jul 28, 2023
Merged

Baryons as in van Daalen+ 2019 #1110

merged 13 commits into from
Jul 28, 2023

Conversation

elisachisari
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jul 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5693985069

  • 51 of 53 (96.23%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 97.432%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyccl/baryons/vandaalen19.py 50 52 96.15%
Totals Coverage Status
Change from base Build 5649619449: -0.01%
Covered Lines: 5730
Relevant Lines: 5881
💛 - Coveralls

damonge
damonge reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just a few first comments.

pyccl/baryons/vandaalen19.py Outdated Show resolved Hide resolved
pyccl/baryons/vandaalen19.py Outdated Show resolved Hide resolved
pyccl/baryons/vandaalen19.py Outdated Show resolved Hide resolved
damonge
damonge reviewed Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!
Just one more comment, and flake8 is complaining.

pyccl/baryons/vandaalen19.py Show resolved Hide resolved
@damonge
Copy link
Collaborator

damonge commented Jul 26, 2023

@elisachisari two final things

  • Flake8 is complaining
  • Can you add a unit test for these lines?
    image

damonge
damonge approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elisachisari
Copy link
Collaborator Author

Comments addressed.

@elisachisari elisachisari reopened this Jul 28, 2023
@elisachisari elisachisari merged commit e218c87 into master Jul 28, 2023
@elisachisari elisachisari deleted the baryons_vd branch July 28, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elisachisari @coveralls @damonge