Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect Python version in CI #1037

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix incorrect Python version in CI #1037

merged 1 commit into from
Mar 21, 2023

Conversation

nikfilippas
Copy link
Contributor

@nikfilippas nikfilippas commented Mar 19, 2023

Some years ago, when the Python package handling in CI was changed to conda, the Python version was still left as a specifier in the matrix. However, this doesn't do anything at all. Conda would just use Python 3.11 (the latest version) even though we had 3.8 specified.

Proof (build from master):

  Package                 Version  Build                Channel                    Size
─────────────────────────────────────────────────────────────────────────────────────────────────
  Install:
─────────────────────────────────────────────────────────────────────────────────────────────────
      ...
  + python                 3.11.0  he550d4f_1_cpython   conda-forge/linux-64       31MB
      ...

This PR moves the Python version inside of the Anaconda environment, so that we use the correct one.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4458802508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.857%

Totals Coverage Status
Change from base Build 4437584140: 0.0%
Covered Lines: 5480
Relevant Lines: 5600

💛 - Coveralls

@damonge
Copy link
Collaborator

damonge commented Mar 20, 2023

Also, what's up with the waiting tests?

@nikfilippas
Copy link
Contributor Author

nikfilippas commented Mar 20, 2023

@damonge they have been replaced because the matrix has changed. We don't test (ubuntu-latest, py38) and (macos-latest, py38) any more. Just ubuntu and macos.

@damonge damonge merged commit f66f18a into master Mar 21, 2023
@damonge damonge deleted the gha_conda_py_version branch March 21, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants