Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python version to 3.8 #1031

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Bump Python version to 3.8 #1031

merged 1 commit into from
Mar 15, 2023

Conversation

nikfilippas
Copy link
Contributor

@nikfilippas nikfilippas commented Mar 15, 2023

Some functionality we just introduced only exists in py38+. I forgot to change that in setup.py. py37's end-of-life is in 3 months either way: https://endoflife.date/python. I should have realized, because we run CI using py38.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4427996058

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.74%

Totals Coverage Status
Change from base Build 4426780279: 0.0%
Covered Lines: 5449
Relevant Lines: 5575

💛 - Coveralls

@damonge damonge merged commit 7372dea into master Mar 15, 2023
@damonge damonge deleted the py37-py38 branch March 15, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants