Disable OpenMP for AppleClang<13 by default #1018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't follow this pr at all. We've built openmp on apple for a long time now. The real problem is the cmake changes, right? |
|
Can't we just roll back the changes made originally for cmake? |
|
Building ccl with AppleClang is mostly fine. However, there will be ImportError in python if libomp is found but not linked correctly. For OpenMP to work with AppleClang12, we need to link libomp with link_libraries in cmake (added in PR1000, but it breaks conda-forge build for arm64) or users need to set LDFLAGS manually. Now I am trying to revert the changes made for cmake while preventing the ImportError problem. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge into PR #1017