Project export window fixes

[zonkmachine]

Two small changes.
Edit: Only one fix left here. The increased number of loops on export.

1 - Fix a glitch in the project export window. Glitch visible with for instance FLAC export.
2 - Increase number of max loops when exporting to 999. I need more. You also need more.

Edit: This issue was on my side and related to os selected screen size.
Buggy file format settings window

Fixed

[szeli1]

I have tested this PR and found that the window sizes work correctly on my system (linux mint, 4k display but full HD resolution used)

Before: (master)

After: (7724)

I'm not sure what is causing this, but it should be looked into, so I don't really want to approve

The code changes look fine

[zonkmachine]

I'm not sure what is causing this, but it should be looked into, so I don't really want to approve

Interesting! I dived into my screen setup to see if I had done anything sketchy and as it turns out there was something that popped up. I had the screen set to max resolution which is higher than the real on board screen. So the graphic card and Qt has been working extra hours to keep up with my demands and reinterpret the screen. The funny thing is that the only glitch I've found so far was that one window in LMMS. Nothing else. I solved it on my side by setting the resolution to the built-in screen and that will work on my side. Considering that no other window glitches on the laptop with wrong setting, maybe there is a better way to draw that window, but I think for now the problem is on my side. If there is something that needs fixing it's for someone else.

Screen Resolution 	‎1366 x 768 pixels
Max Screen Resolution 	‎1920 x 1080 Pixels 

Thanks for the review!

[zonkmachine]

Reopened for the loop export fix.

[tresf]

This is an odd PR because the history for it says a lot more than what it does. What I can read from the diff is that someone wanted to have segments looped more than 99 times. I'm not sure where this value was chosen from and I'm also not sure where 999 comes from. I see no reason to make this anything less than what the underlying model value supports. That said, no objections.

[zonkmachine]

This is an odd PR because the history for it says a lot more than what it does.

Yes. It got messy as the original start of this PR was invalid and I choose to force push. Messy. Tempting to make a separate new PR instead.

Loop length

At 99 maximum loops a one measure beats exported length is 3m 18s.
Increasing the number of loops to 999 will allow a beat to loop for 33m 17s.
Half an hour is not long enough for a soundscape but you could quite easily extend the loop and re-export. But I wonder why there is a maximum in the first place. If a user want's to loop a track for a very long time maybe there shouldn't be an upper limit or it should be longer. 9999?
According to my friend Grok, wav file tap out at almost seven hours.

So, for a standard WAV file at 44.1 kHz, 16-bit, stereo, the maximum sample length is about 6.75 hours.

When I export a 1 measure loop 9999 times at 120 bpm it comes out at 3h 22m 53s.
I think this sounds better actually. It would allow the user to experiment more and it won't glitch out at those export lengths.

Should I open a new PR?

[tresf]

I wonder why there is a maximum in the first place

Agreed.

tap out at almost seven hours.

Right because 4GB size limit, but that's only WAV. Other output formats would behave differently. I don't see a reason to set a limit.

Should I open a new PR?

Maybe I misunderstand.... What's wrong with this one?

[zonkmachine]

Should I open a new PR?

Maybe I misunderstand.... What's wrong with this one?

As per this comment:

This is an odd PR because the history for it says a lot more than what it does.

I can make a cleaner one.

[tresf]

Should I open a new PR?

Maybe I misunderstand.... What's wrong with this one?

As per this comment:

This is an odd PR because the history for it says a lot more than what it does.

I can make a cleaner one.

Oh! No need for a new PR, it was more of a casual observation.

[zonkmachine]

I bumped the value to 9999 and exported an organ loop with random arpeggiator elements, filter sweep, and delay/reverb, over some five hours in both wav and ogg and it was glorious.

I had a go at removing the loop count maximum completely but it would default to 99 anyway. It looks like some default value in Qt or at least not as something I can do anything about. Just bumping the maximum number of loops seem to me as an acceptable tradeoff.

[tresf]

If there's nothing preventing it, should the max be the underlying model max? (e.g INT_MAX, UINT_MAX or whatever?)

[zonkmachine]

it would default to 99 anyway. It looks like some default value in Qt or at least not as something I can do anything about.

Yes, the default max for a QSpinBox in Qt Designer is indeed 99 (arbitrary default set by the tool). Same as our old max.

If there's nothing preventing it, should the max be the underlying model max? (e.g INT_MAX, UINT_MAX or whatever?)

You would need to do that from on the c++ side and not in the Qt .ui file (xml) it's going to increase the complexity. This means that someone else need to fix this (which I'm perfectly fine with). It sounds like quite a bit of an overkill since now you can loop it for some fiver hours and if you need more, and off course there is people out there that do, there's always someone..., but in that case you can extend the pattern to be longer than one measure. We used to be limited to ~3 minutes and now it's ~6 or so hours. Good enough for me. ;)

[tresf]

You would need to do that from on the c++ side and not in the Qt .ui file (xml) it's going to increase the complexity.

No, sorry, I didn't mean to suggest that we calculate it from C++, I meant to steal a sane value from C++. For example, if unsigned integer on 32-bit is a baseline, perhaps a value of 4294967295 because it goes from arbitrary/magic to justifiable. That's all.

[zonkmachine]

For example, if unsigned integer on 32-bit is a baseline, perhaps a value of 4294967295 because it goes from arbitrary/magic to justifiable. That's all.

OK. Grok says:

Default max in Qt Designer: 99 (arbitrary default set by the tool).

Absolute max for QSpinBox: 2147483647 (limited by int).

You can set any value up to 2147483647 in the .ui file or programmatically.

For larger values, switch to QDoubleSpinBox.

So...

Sure about this... 🥲

[tresf]

We may not have enough time in our life to test out this value, but it makes sense (mathematically) works and doesn't crash, merging.

[zonkmachine]

merging

K. I'll Squash/merge after the tests have run.

[tresf]

merging

K. I'll Squash/merge after the tests have run.

Oh, I'll hold off and let you do it then... almost... pressed.... it.

[zonkmachine]

Oh, I'll hold off and let you do it then... almost... pressed.... it.

Perfectly fine to just merge...