-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix libjack.so.0 detection for openSUSE #7690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing: Tests are a bit crude. I test WITH jack and WITHOUT jack. To simulate a system without jack, I simply move the binary, e.g:
|
sakertooth
pushed a commit
to sakertooth/lmms
that referenced
this pull request
Feb 17, 2025
Fix libjack.so.0 detection for openSUSE Add libdb-5.so to optional as symlink
Rossmaxx
pushed a commit
to Rossmaxx/lmms
that referenced
this pull request
Mar 1, 2025
Fix libjack.so.0 detection for openSUSE Add libdb-5.so to optional as symlink
Rossmaxx
pushed a commit
to Rossmaxx/lmms
that referenced
this pull request
Mar 3, 2025
Fix libjack.so.0 detection for openSUSE Add libdb-5.so to optional as symlink
Rossmaxx
pushed a commit
to Rossmaxx/lmms
that referenced
this pull request
Mar 3, 2025
Fix libjack.so.0 detection for openSUSE Add libdb-5.so to optional as symlink
Rossmaxx
pushed a commit
to Rossmaxx/lmms
that referenced
this pull request
Mar 3, 2025
Fix libjack.so.0 detection for openSUSE Add libdb-5.so to optional as symlink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nightly installs so that they'll start on openSUSE
libjack.so.0
fromusr/lib/lmms/optional
tousr/lib/jack
(cosmetic decision)app-hooks/jack-apphook.sh
to preferldd
insteadlibdb
alongsize jackBackground:
The bug is caused by #7686 where we stopped looking in
sbin
forldconfig
however this PR changes the script to useldd
instead (a technique preferred after working on #7686 for reliability purposes).The bug also exposed a new problem with our launcher; for systems that DO need our jack-apphook workaround,
libdb-5.3.so
is missing, which prevents LMMS from starting. This is solved by placing a symlink forlibdb-5.3.so
adjacent tolibjack.so.0
. We do this dynamically (preferringldd
again) for when this version inevitably changes.Closes #7689