Feature: Carla automation #5846

cyber-bridge · 2020-12-12T21:35:42Z

Continuation of #4571

What has changed since #4571:

Added plugin groups (Multiple plugin support).
Added MACRO's so it also compiles with older versions of Carla which don't support the params.
Params are automaticly refreshed when something with the plugins in Carla has changed.
The amount of params (knobs) in a row will now depend on the params window it's width and the largest knob width.

TODO:

Save/load params window state.
~~Remove debug code~~
~~Code style~~

LmmsBot · 2020-12-12T21:41:50Z

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

Windows 64-bit: lmms-1.3.0-alpha.1.139%2Bg714e19972-mingw-win64.exe (build link)
Windows 32-bit: lmms-1.3.0-alpha.1.139%2Bg714e19972-mingw-win32.exe (build link)
Windows 32-bit: lmms-1.3.0-alpha-msvc2017-win32.exe (build link)
Windows 64-bit: lmms-1.3.0-alpha-msvc2017-win64.exe (build link)

Linux

Linux (AppImage): lmms-1.3.0-alpha.1.139%2Bg714e199-linux-x86_64.AppImage (build link)

macOS

macOS : lmms-1.3.0-alpha.1.139%2Bg714e19972-mac10.14.dmg (build link)

🤖

{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://14088-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.139%2Bg714e19972-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14088?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://14087-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.139%2Bg714e19972-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14087?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/02fyitfeo8kkj54v/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/39706821"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/2jay67faltly3tra/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/39706821"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://14089-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.139%2Bg714e199-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14089?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://14086-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.139%2Bg714e19972-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14086?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "ffd4662e59122de12fb4cf73f9c31cd73ca83d0b"}

PhysSong · 2020-12-26T02:45:32Z

@falkTX Could you check if interactions with Carla are correct?

arthurdead · 2021-01-14T09:36:23Z

pre-built version based on ca17641 with this PR applied
target.zip
seems to be working fine i got a crash while testing but i dont remember what i did and it hasnt happened since then

i would make a appimage but the script doenst work on my machine

tinkerlevu · 2021-01-14T12:14:38Z

Yeah, I would also like to get an appimage to test out, but that build has expired and my dependencies are a mess...

tinkerlevu · 2021-01-15T13:22:18Z

(Finally) managed to build an Appimage based on 97114fb

From my limited testing so far, Carla automation and everything seems to work fine.

For anyone else who may want to test out and/or access this feature early, here it is: lmms-1.3.0-alpha.1.44+g97114fb-linux-x86_64.AppImage

also for some reason, this PR doesn't really show up on google when you search for 'lmms carla automation'... *annoying*

tinkerlevu · 2021-01-19T07:52:38Z

Just a few minor niggles after playing around with it (#5846 (comment)):

Connected knobs do not immediately disappear if all linked automation tracks and/or controllers are deleted while 'Show only knobs with a connection' filter is enabled in the Parameters dialog. This might be intentional or desirable behavior idk.
I had a small crash with one of the Calf compressors while aimlessly playing around with its threshold settings rapidly in the Carla parameters window with my mouse (also while a midi controller connected to that param through Carla.)
- cannot reproduce.
- probably unrelated.
All my Carla Parameters were lost and reset to default after a crash.
- crash was due to a completely separate issue (Undo in Song Editor Fails After Duplicating Multiple Midi Reigions #5885)
- probably unrelated, and the fault lies elsewhere.

Other than that this seems really solid! and it makes Carla an absolute joy to use! Great work 👍🎉🎉

cyber-bridge · 2021-01-19T22:55:27Z

@tinkerlevu thanks for testing! 1. Good find, it Isn't intentional; I simply forgot about that case, will fix it.

tinkerlevu · 2021-01-20T04:27:18Z

@cyber-bridge It's the least I could do... (^u^)

Really hope this gets merged man...

plugins/carlabase/carla.h

cyber-bridge · 2021-01-30T22:28:24Z

@PhysSong Moved those members to CarlaInstrumentView, also gave them better names.

plugins/carlabase/carla.cpp

cyber-bridge · 2021-01-31T13:06:43Z

@PhysSong thanks! I don't know how I managed that :') normally I compile before pushing, must have forgotten.

cyber-bridge · 2021-04-10T18:01:10Z

I've just finished reviewing the code and found some issues, feel free to comment. Will address those issues soon.

plugins/carlabase/carla.cpp

plugins/carlabase/carla.h

plugins/carlabase/carla.cpp

- Removed unused function modelChanged().

…LL to nullptr. Removed unnescerarry check.

+ Renamed 'maxWidth' to 'maxKnobWidth' 'cause that's what it is.

…stency. Methods: - CarlaInstrument::clearKnobModels() to CarlaInstrument::clearParamModels() - CarlaInstrument::knobModelChanged() to CarlaInstrument::paramModelChanged() - CarlaInstrument::updateKnobModel() to CarlaInstrument::updateParamModel() Members: - m_knobGroupCount to m_paramGroupCount

JohannesLorenz · 2021-06-22T19:29:22Z

@cyber-bridge Do you think this can be merged without further review? I ask because because this is one of the latest pre-refactor branches. But if you think more review is required, that's also OK.

cyber-bridge · 2021-06-24T11:28:00Z

@JohannesLorenz , yes I think merging would be a good thing; I'll be available for bug review/fixing when they get reported.

"Save/load params window state." is still TODO but could be added later.

There is also this #5846 (comment) (issue 1.) ; I've looked into the issue but there isn't a easy fix I'm aware of and I'll think it will need some code changes in LMMS itself to get notified when a model gets disconnected. The other two issues (2. and 3.) mentioned in that comment I could not reproduce and are probably unrelated as also mentioned in the comment.

JohannesLorenz · 2021-06-28T19:02:49Z

OK, thanks. These seem all minor things to me, I'm happy to merge this.

JohannesLorenz · 2021-06-28T19:03:45Z

Oh, should I squash all into one commit @cyber-bridge ? Do you have a descriptive commit message?

cyber-bridge · 2021-06-30T17:47:51Z

@JohannesLorenz yeah squashing will be good 👍

Expose Carla parameters for automation.

A new button called "Params" is added to the Carla instrument window; on press
it will open a new sub-window where Carla parameters can be found, ready for
connecting to a automation-track or controller. The exposed parameters in the
sub-window can be filtered by text and there is the ability to display only
parameters that are connected to a automation-track or controller. When there
are multiple plugins loaded inside Carla, the combo-box inside the (LMMS)
parameters sub-window can be used to switch between parameters of a specific
plugin (Carla).

Notes:

 - Available when compiled with Carla version 2.1 and up.
 - Currently Carla (2.1) will expose a maximum of 110 parameters.
 - The param window state isn't stored yet in a LMMS project, this is still
   TODO.
 - Connected paramters will NOT instantly disappear when they are disconnected
   with the "Show only knobs with a connection" filter enabled. See
   https://github.com/LMMS/lmms/pull/5846#issuecomment-762666428

JohannesLorenz · 2021-06-30T18:00:12Z

Merged. Thanks a lot for the contribution 👍

A new button called "Params" is added to the Carla instrument window; on press it will open a new sub-window where Carla parameters can be found, ready for connecting to a automation-track or controller. The exposed parameters in the sub-window can be filtered by text and there is the ability to display only parameters that are connected to a automation-track or controller. When there are multiple plugins loaded inside Carla, the combo-box inside the (LMMS) parameters sub-window can be used to switch between parameters of a specific plugin (Carla). Notes: - Available when compiled with Carla version 2.1 and up. - Currently Carla (2.1) will expose a maximum of 110 parameters. - The param window state isn't stored yet in a LMMS project, this is still TODO. - Connected paramters will NOT instantly disappear when they are disconnected with the "Show only knobs with a connection" filter enabled. See LMMS#5846 (comment)

PhysSong mentioned this pull request Dec 12, 2020

Add Carla automation support #4571

Closed

tinkerlevu mentioned this pull request Jan 17, 2021

Crash When Carla Rack or Patchbay is Replaced #5883

Open

PhysSong reviewed Jan 30, 2021

View reviewed changes

plugins/carlabase/carla.h Outdated Show resolved Hide resolved

PhysSong reviewed Jan 31, 2021

View reviewed changes

plugins/carlabase/carla.cpp Outdated Show resolved Hide resolved

IanCaio mentioned this pull request Mar 23, 2021

PSA: New PRs may be affected by refactor #5836

Closed

Spekular mentioned this pull request Mar 26, 2021

Reorganising LMMS, renaming editors and classes and everything in between (cont. #120) #5592

Closed

56 tasks

cyber-bridge commented Apr 10, 2021

View reviewed changes

CYBERDEViL added 11 commits April 11, 2021 19:30

Updated work on Carla parameters to latest LMMS master branch.

21b5478

Update Carla UI after a knob changed from LMMS

1e29794

Grow/shrink layout when the params subwindow changes width.

4adf8a5

Fix crash on delete last plugin from carla (no params left).

9d9cfe4

- Display Carla params correctly on first show.

ab851c4

- Removed unused function modelChanged().

Prevent posible division by zero.

4a26a08

Move GUI stuff from CarlaInstrument to CarlaInstrumentView. Rename NU…

8a0f209

…LL to nullptr. Removed unnescerarry check.

Some better naming.

df3f7d9

Style: honor max line length of 120 characters.

6f283b4

Remove some whitespaces and adjusted comment.

9cd5cf0

Remove debug code.

f5fcb27

CYBERDEViL added 3 commits April 11, 2021 19:30

Fix fatal typo

305bc02

Address some minor [naming] coding conventions issues.

fececb5

Remove the +1, it was left-over from experimenting.

73d9e26

cyber-bridge force-pushed the carla_dev branch from e4bf951 to 49e91a3 Compare June 9, 2021 12:41

CYBERDEViL and others added 7 commits June 9, 2021 15:26

Fix the calculation of how many knobs will fit in a row.

25fb33b

+ Renamed 'maxWidth' to 'maxKnobWidth' 'cause that's what it is.

Make sure param models are deleted in instrument destructor.

c17494b

Forgot to add carla.h in the previous commit.

2ff65b2

Code style blocking.

a2c6d95

Code style pointers

49e91a3

Fix lambda capture after review

ffd4662

JohannesLorenz merged commit f8d7fa3 into LMMS:master Jun 30, 2021

Rampoina mentioned this pull request Mar 31, 2023

lmms: Add support for Carla NixOS/nixpkgs#223103

Merged

12 tasks

Lazerbeak12345 mentioned this pull request Sep 2, 2023

Use Carla as an effect. #4634

Open

enp2s0 mentioned this pull request Feb 15, 2024

Regression: Carla instruments do not save/load properly; sound completely different after reload #7104

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Carla automation #5846

Feature: Carla automation #5846

cyber-bridge commented Dec 12, 2020 •

edited

Loading

LmmsBot commented Dec 12, 2020 •

edited

Loading

Windows

Linux

macOS

PhysSong commented Dec 26, 2020

arthurdead commented Jan 14, 2021

tinkerlevu commented Jan 14, 2021 •

edited

Loading

tinkerlevu commented Jan 15, 2021

tinkerlevu commented Jan 19, 2021

cyber-bridge commented Jan 19, 2021 via email

tinkerlevu commented Jan 20, 2021

cyber-bridge commented Jan 30, 2021 via email

cyber-bridge commented Jan 31, 2021 via email

cyber-bridge commented Apr 10, 2021

JohannesLorenz commented Jun 22, 2021

cyber-bridge commented Jun 24, 2021

JohannesLorenz commented Jun 28, 2021

JohannesLorenz commented Jun 28, 2021

cyber-bridge commented Jun 30, 2021

JohannesLorenz commented Jun 30, 2021

Feature: Carla automation #5846

Feature: Carla automation #5846

Conversation

cyber-bridge commented Dec 12, 2020 • edited Loading

LmmsBot commented Dec 12, 2020 • edited Loading

Windows

Linux

macOS

PhysSong commented Dec 26, 2020

arthurdead commented Jan 14, 2021

tinkerlevu commented Jan 14, 2021 • edited Loading

tinkerlevu commented Jan 15, 2021

tinkerlevu commented Jan 19, 2021

cyber-bridge commented Jan 19, 2021 via email

tinkerlevu commented Jan 20, 2021

cyber-bridge commented Jan 30, 2021 via email

cyber-bridge commented Jan 31, 2021 via email

cyber-bridge commented Apr 10, 2021

JohannesLorenz commented Jun 22, 2021

cyber-bridge commented Jun 24, 2021

JohannesLorenz commented Jun 28, 2021

JohannesLorenz commented Jun 28, 2021

cyber-bridge commented Jun 30, 2021

JohannesLorenz commented Jun 30, 2021

cyber-bridge commented Dec 12, 2020 •

edited

Loading

LmmsBot commented Dec 12, 2020 •

edited

Loading

tinkerlevu commented Jan 14, 2021 •

edited

Loading