Fix crash on OGG export with Qt >= 5.10 #5813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://1203-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-782%2Bga5de839-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1203?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1204-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-782%2Bga5de83937-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1204?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1201-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-782%2Bga5de83937-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1201?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/dopm8pqv0eh6k06m/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36571484"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/sv086iaefhtfpb25/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36571484"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://1205-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-782%2Bga5de83937-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1205?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "a5de839379018a6a6594ad4429b71ddfb00113b2"} |
PhysSong
changed the title
|
Tested locally, seems to be working! |
zonkmachine
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Rock solid. I thought qrandomgenerator would be seeded with a default 1 if you didn't specify a seed and therefore spit out the same values when you restart lmms. QRandomGenerator::global(), not so much. I've tested this and confirmed the randomness of the exported files serial number and it works just fine. Merge.
IanCaio
pushed a commit
to IanCaio/lmms
that referenced
this pull request
Mar 28, 2021
devnexen
pushed a commit
to devnexen/lmms
that referenced
this pull request
Apr 10, 2021
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5619 (comment).
Thanks to
@Rdrpenguin#0256on Discord for reporting.