Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LV2 with MSVC #5730

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Support LV2 with MSVC #5730

merged 3 commits into from
Oct 31, 2020

Conversation

DomClark
Copy link
Member

Allows building LV2 support for Windows using MSVC. Adds the required vcpkg ports to .appveyor.yml, changes CMakeLists.txt to be able to use these ports, and makes a few small changes required to successfully compile under MSVC.

@LmmsBot
Copy link

LmmsBot commented Oct 24, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://10007-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-743%2Bg4a1263d-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10007?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://10008-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-743%2Bg4a1263d79-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10008?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://10006-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-743%2Bg4a1263d79-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10006?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/a2rlekin45u8uf3c/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36028638"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/qwaid31l8e2np0an/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36028638"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://10005-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-743%2Bg4a1263d79-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10005?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "704de9501d4f196889e7500f61b38a876b8b6437"}

@DomClark DomClark requested a review from PhysSong October 24, 2020 20:57
@DomClark DomClark added needs code review A functional code review is currently required for this PR needs testing This pull request needs more testing labels Oct 26, 2020
@superpaik
Copy link
Contributor

I don't know if that is correct for testing, but I installed the Windows 64-bit made by the boot and lv2 pluggins are not available. On the LMMS starting page you can read "Lv2 plugin SUMMARY: 0 of 0 loaded in 0 msecs"
imatge

@DomClark
Copy link
Member Author

LMMS doesn't ship with any LV2 plugins by default. You can install some free ones for Windows from https://x42-plugins.com/x42/, for example.

@superpaik
Copy link
Contributor

Sorry, my fault.
I installed a couple of effects (using "Windows 64-bit: lmms-1.2.2-msvc2017-win64.exe" for testing) and it worked ok.

@DomClark DomClark removed the needs testing This pull request needs more testing label Oct 27, 2020
Copy link
Contributor

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left only one minor comment about the STATUS_LV2 message in CMake. LGTM.

@DomClark DomClark removed the request for review from PhysSong October 29, 2020 01:38
@DomClark
Copy link
Member Author

Will merge in a day or two if there are no objections.

@DomClark
Copy link
Member Author

Merge?

@JohannesLorenz
Copy link
Contributor

@DomClark for your info (it's not a comment stopping this PR): We have a new Lv2 wiki page. If compiling LMMS with Lv2 (or installing Lv2) is nontrivial, you can add the steps there. Also, you can add instructions how to install the plugins on Windows, if it's not obvious.

@tresf
Copy link
Member

tresf commented Oct 30, 2020

Merge?

Yes. I pointed out some wording that seems to be geared towards systems without pkg-config, which I believe @JohannesLorenz originally authored when suil was added in 2a66e83, but shouldn't hold this up. I'm just a bit confused who this wording was intended to target since pkg-config has been a requirement of LMMS as long as I can remember. :)

@DomClark
Copy link
Member Author

@JohannesLorenz Thanks for the wiki link - I'll add the relevant information once this is merged. Compiling with LV2 should be easy (just vcpkg install lilv lv2), but the ports are quite new so anyone who's compiled LMMS on Windows before may need to update vcpkg first. Installing LV2 plugins is easy enough - the hard part is finding them, since it's not a common format on Windows and there's no package manager to search for them. I'll add a link to x42's plugins to get people started.

@tresf tresf removed the needs code review A functional code review is currently required for this PR label Oct 30, 2020
@DomClark DomClark merged commit 615d36b into LMMS:master Oct 31, 2020
@DomClark DomClark deleted the lv2-msvc branch October 31, 2020 13:29
IanCaio pushed a commit to IanCaio/lmms that referenced this pull request Mar 28, 2021
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants