-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LV2 with MSVC #5730
Support LV2 with MSVC #5730
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://10007-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-743%2Bg4a1263d-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10007?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://10008-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-743%2Bg4a1263d79-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10008?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://10006-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-743%2Bg4a1263d79-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10006?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/a2rlekin45u8uf3c/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36028638"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/qwaid31l8e2np0an/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36028638"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://10005-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-743%2Bg4a1263d79-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10005?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "704de9501d4f196889e7500f61b38a876b8b6437"} |
LMMS doesn't ship with any LV2 plugins by default. You can install some free ones for Windows from https://x42-plugins.com/x42/, for example. |
Sorry, my fault. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left only one minor comment about the STATUS_LV2
message in CMake. LGTM.
Will merge in a day or two if there are no objections. |
Merge? |
@DomClark for your info (it's not a comment stopping this PR): We have a new Lv2 wiki page. If compiling LMMS with Lv2 (or installing Lv2) is nontrivial, you can add the steps there. Also, you can add instructions how to install the plugins on Windows, if it's not obvious. |
Yes. I pointed out some wording that seems to be geared towards systems without |
@JohannesLorenz Thanks for the wiki link - I'll add the relevant information once this is merged. Compiling with LV2 should be easy (just |
Allows building LV2 support for Windows using MSVC. Adds the required vcpkg ports to
.appveyor.yml
, changesCMakeLists.txt
to be able to use these ports, and makes a few small changes required to successfully compile under MSVC.