-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "FX-Mixer" to "Mixer". #4890
Conversation
Ordinarily we'd target changes like this to Also while you're at it, I'd personally be for changing variable names, though this is significantly more error-prone. Also I'm not as regular of a contributor as some others, so I'll let someone else weigh in on that. |
Ah, alright, makes sense. Can I change this now to target to master? Will also change variable names etc. |
Before you target master, let's make sure nobody has objections to targeting You can't just change the target to master without breaking a lot. You would have to:
|
Ok. Have created some more commits now to hopefully rename all instances of FX Mixer. I split it up into many commits to make it easier to follow the search and replace changes. |
All changes should be tested. If not, you're asking the developers to test for you, which is asking them to work on a task you invented.
Why cause inconsistencies in the codebase? |
Alright.
Well, I did not invent it, but ok. Is there a build artifact that I can use for easy testing?
I don't know, I just heard that FX Mixer should be renamed to Mixer, so I thought why not go all the way. If this is not wanted, just say. Then I will try to only rename the relevant Strings. |
|
Closing to create another PR for |
Closes #3300 (hopefully, if not sorry for wasting your time!).
I currently only renamed String texts imho, but can also rename classes, variable names etc.
Not tested.