Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SPA support (enabling zyn-fusion) #4662

Closed
wants to merge 144 commits into from

Merge branch 'master' into osc-plugin

4aa9ad6
Select commit
Loading
Failed to load commit list.
Closed

Implement SPA support (enabling zyn-fusion) #4662

Merge branch 'master' into osc-plugin
4aa9ad6
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Feb 16, 2025 in 3s

11 issues fixed. 20 issues found.

Annotations

Check notice on line 205 in src/core/SpaManager.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/SpaManager.cpp#L144-L205 

Complex Method

Check notice on line 51 in plugins/SpaEffect/SpaEffect.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaEffect/SpaEffect.cpp#L51 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 66 in plugins/SpaInstrument/SpaInstrument.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaInstrument/SpaInstrument.cpp#L66 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 105 in plugins/SpaInstrument/SpaInstrument.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaInstrument/SpaInstrument.h#L105 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

Check notice on line 102 in plugins/SpaEffect/SpaEffect.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaEffect/SpaEffect.cpp#L102 

Redundant blank line at the start of a code block should be deleted. (whitespace/blank_line)

Check notice on line 261 in plugins/SpaInstrument/SpaInstrument.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaInstrument/SpaInstrument.cpp#L261 

Redundant blank line at the start of a code block should be deleted. (whitespace/blank_line)

Check notice on line 269 in plugins/SpaInstrument/SpaInstrument.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaInstrument/SpaInstrument.cpp#L269 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 274 in src/core/SpaProc.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/SpaProc.cpp#L190-L274 

Complex Method

Check notice on line 114 in include/SpaViewBase.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

include/SpaViewBase.h#L114 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

Check notice on line 109 in plugins/SpaEffect/SpaEffect.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaEffect/SpaEffect.cpp#L109 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 49 in include/SpaSubPluginFeatures.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

include/SpaSubPluginFeatures.h#L49 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

Check notice on line 37 in plugins/SpaEffect/SpaEffect.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaEffect/SpaEffect.cpp#L37 

Redundant blank line at the start of a code block should be deleted. (whitespace/blank_line)

Check notice on line 52 in plugins/SpaInstrument/SpaInstrument.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaInstrument/SpaInstrument.cpp#L52 

Redundant blank line at the start of a code block should be deleted. (whitespace/blank_line)

Check notice on line 1223 in src/gui/FileBrowser.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/gui/FileBrowser.cpp#L1149-L1223 

Complex Method

Check notice on line 327 in include/Plugin.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

include/Plugin.h#L327 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 220 in src/gui/SpaViewBase.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/gui/SpaViewBase.cpp#L93-L220 

Complex Method

Check notice on line 424 in include/AutomatableModel.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

include/AutomatableModel.h#L424 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 96 in include/SpaControlBase.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

include/SpaControlBase.h#L96 

Do not leave a blank line after "protected:". (whitespace/blank_line)

Check notice on line 48 in plugins/SpaEffect/SpaFxControlDialog.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

plugins/SpaEffect/SpaFxControlDialog.h#L48 

"virtual" is redundant since function is already declared as "override". (readability/inheritance)

Check notice on line 1281 in src/gui/editors/AutomationEditor.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/gui/editors/AutomationEditor.cpp#L940-L1281 

Complex Method
View more details on codefactor.io