Use bundled jack if missing #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several systems don't ship with a jack version by default leaving missing symbols on launch.
This attempts to fix that by bundling a version of jack from the system and adding it to
LD_LIBRARY_PATHat launch time if the launcher script can't find a suitable one.This might still crash with undefined symbols on systems using jack1 instead of jack2, but we don't have the luxury to recompile some of our dependant libraries with
weakjackso I'm not sure we can easily fix that. One possibility is to take the script a bit further and inspect the exact jack version and still do the override for jack1 systems, but I'm not sure how difficult this is. Anyway...Closes #4094