Proposed fix for 1345 Exclude tracks from master pitch

[curlymorphic]

Proposed fix for #1345 Exclude tracks from master pitch

[tresf]

Creative... I like the departmentalization of this button (and possibly more to come eventually, right? :) )

Can we use styling that is more consistent with the other tabs?

[curlymorphic]

sure,

Can we use styling that is more consistent with the other tabs?

sure.

so a groupbox, with the checkbox in the header, and the description as the content text>

[tresf]

👍

[curlymorphic]

How is the wording and layout on this?

[tresf]

I like the word "inherit" and "break inheritance" personally. More opinions welcome.

[curlymorphic]

My use of words is sometimes not the best :(, so really im after 2 lines

1. Group box heading (currently "MASTER PITCH")
2. description text (currently "Enables the use of master pitch")

[tresf]

I would vote:

[ . ] INHERIT MASTER PITCH
When unchecked, this instrument ignores the master pitch slider.

Which puts a bit of help text in there (something we don't normally do) so opinions welcome @Umcaruje @StakeoutPunch

[tresf]

Also @curlymorphic the font size looks a bit large in you preview. Is that normal for your computer, or is there something off in the code/CSS?

[curlymorphic]

@tresf

Also @curlymorphic the font size looks a bit large in you preview. Is that normal for your computer, or is there something off in the code/CSS?

it was me. Have now copied the relevant line of code from the midi tab to keep consistency.

Another Screenshot showing proposed text, with a midi tab open for comparision.

[tresf]

Well done. If people have issues with the text, we can make those tweaks later. Thanks!!!

[curlymorphic]

Sorry that was only a screen shot, i had not updated the pull request.

will do so now

[Sti2nd]

The first text wasn't understandable, the last is. :)