Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GigPlayer Windows build #1591

Merged
merged 1 commit into from
Jan 11, 2015
Merged

Enable GigPlayer Windows build #1591

merged 1 commit into from
Jan 11, 2015

Conversation

DanWin
Copy link
Contributor

@DanWin DanWin commented Jan 10, 2015

This enables GigPlayer builds for windows.
I had to add the -Wno-deprecated compiler flag to fix a bunch of these errors caused by an include file in the mingw-x-libgig package:
/opt/mingw32/include/gig.h:434:13: error: access declarations are deprecated in favour of using-declarations; suggestion: add the 'using' keyword [-Werror=deprecated]
DLS::Sampler::UnityNote;
^

add_definitions(${GCC_GIG_COMPILE_FLAGS})
endif(LMMS_BUILD_WIN32)

LINK_DIRECTORIES(${GIG_LIBRARY_DIRS} ${SAMPLERATE_LIBRARY_DIRS})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanWin. What is the SAMPLERATE_LIBRARY_DIRS for exactly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tresf I don't know, seams to work even without, but they were were also in sf2_player, so I just copied it from there.

@DanWin
Copy link
Contributor Author

DanWin commented Jan 10, 2015

Hm, the build is failing, because the package is missing in the ppa. I was using the trusty version of the ppa, not the precise one. We should add the mingw-x-libgig package to the ppa repository before merging.

@DanWin
Copy link
Contributor Author

DanWin commented Jan 10, 2015

@tobydox You should have a look into your ppa, mingw-x-libgig has failed building for precise.

@tresf
Copy link
Member

tresf commented Jan 10, 2015

@tobydox You should have a look into your ppa, mingw-x-libgig has failed building for precise.

He's fully aware. It was a wontfix problem last we discussed this (tried digging up the thread to no avail). His recommendation was to move to 14.04. It will also prevent us from deploying 1.2 using Travis. 😕

@tresf
Copy link
Member

tresf commented Jan 10, 2015

@lukas-w if you can offer some opinions on this, it would be greatly appreciated. Merging this helps the project but breaks Travis. Sadface.

@lukas-w
Copy link
Member

lukas-w commented Jan 10, 2015

I think the easiest solution would be to fix the libgig package for 12.04. Travis is using 12.04 and we can't change that.
The only alternative I see is migrating to a different CI service. https://semaphoreapp.com offers Ubuntu 14.04.

@tresf
Copy link
Member

tresf commented Jan 10, 2015

I think the easiest solution would be to fix the libgig package for 12.04. Travis is using 12.04 and we can't change that.

I'm inclined to agree... Does this fall on Toby, or do we start investigating cross-building and ppa hosting or a mix of the two?

@tobydox
Copy link
Member

tobydox commented Jan 10, 2015

libgig finally has been built successfully for Precise so you can use it in Travis CI as well.

@lukas-w
Copy link
Member

lukas-w commented Jan 11, 2015

Great, thanks Toby! :)

CMake in Travis can't seem to find libgig:

* GIG player                  : not found, libgig needed for decoding .gig files

@DanWin
Copy link
Contributor Author

DanWin commented Jan 11, 2015

@lukas-w In the first run it isn't found, but on the second run it is, same as libfluidsynth-dev for sf2_player. That's why the windows CMake file is invoked twice. If you scroll down in the travis log, you should actually see:

  • GIG player : not found, libgig needed for decoding .gig files (line 438)
  • GIG player : OK (line 507)

@lukas-w
Copy link
Member

lukas-w commented Jan 11, 2015

Ah yes, forgot about that, thanks @DanWin

lukas-w added a commit that referenced this pull request Jan 11, 2015
Enable GigPlayer Windows build
@lukas-w lukas-w merged commit a52626b into LMMS:master Jan 11, 2015
@DanWin DanWin deleted the win_gigplayer branch January 11, 2015 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants