-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GigPlayer Windows build #1591
Conversation
add_definitions(${GCC_GIG_COMPILE_FLAGS}) | ||
endif(LMMS_BUILD_WIN32) | ||
|
||
LINK_DIRECTORIES(${GIG_LIBRARY_DIRS} ${SAMPLERATE_LIBRARY_DIRS}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DanWin. What is the SAMPLERATE_LIBRARY_DIRS
for exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tresf I don't know, seams to work even without, but they were were also in sf2_player, so I just copied it from there.
Hm, the build is failing, because the package is missing in the ppa. I was using the trusty version of the ppa, not the precise one. We should add the mingw-x-libgig package to the ppa repository before merging. |
@tobydox You should have a look into your ppa, mingw-x-libgig has failed building for precise. |
He's fully aware. It was a |
@lukas-w if you can offer some opinions on this, it would be greatly appreciated. Merging this helps the project but breaks Travis. Sadface. |
I think the easiest solution would be to fix the |
I'm inclined to agree... Does this fall on Toby, or do we start investigating cross-building and ppa hosting or a mix of the two? |
libgig finally has been built successfully for Precise so you can use it in Travis CI as well. |
Great, thanks Toby! :) CMake in Travis can't seem to find libgig:
|
@lukas-w In the first run it isn't found, but on the second run it is, same as libfluidsynth-dev for sf2_player. That's why the windows CMake file is invoked twice. If you scroll down in the travis log, you should actually see:
|
Ah yes, forgot about that, thanks @DanWin |
Enable GigPlayer Windows build
This enables GigPlayer builds for windows.
I had to add the -Wno-deprecated compiler flag to fix a bunch of these errors caused by an include file in the mingw-x-libgig package:
/opt/mingw32/include/gig.h:434:13: error: access declarations are deprecated in favour of using-declarations; suggestion: add the 'using' keyword [-Werror=deprecated]
DLS::Sampler::UnityNote;
^