Rename old style classes and files [wip]

[lukas-w]

Welcome to my great suicidal attempt at renaming all classes and files to fit the new C++ style.
I keep this pull request for checking my changes with Travis and to apologize for the countless merge conflicts lying ahead.

[diizy]

Ok yeah, this is admirable but we should hold this off for a bit... so
much conflicts.

[tresf]

my great suicidal attempt at renaming all classes and files to fit the new C++ style

Sounds like a mission for a ninja with ninja skills. 👍 Moral support.

@diizy, when you say "hold off", are you asking him not to work on the pull, or "hold off" before merging the pull? Since it's a WIP, he'll be in conflict hell in any scenario without a code freeze, right?

I'm asking not because I question anyone's judgement, just want to learn. :)

[diizy]

On 11/26/2014 05:44 AM, Tres Finocchiaro wrote:

my great suicidal attempt at renaming all classes and files to fit
the new C++ style

Sounds like a mission for a ninja with ninja skills. 👍 Moral support.

@diizy https://github.com/diizy, when you "hold off", are you asking
him not to work on the pull, or "hold off" before merging the pull?
Since it's a WIP, he'll be in conflict hell in any scenario without a
code freeze, right?

I'm asking not because I question anyone's judgement, just want to
learn. :)

Well I'm mainly concerned because there's so much stuff going on right
now... there's the lmms2 branch where I'm trying to start up the efforts
to redesign and clean up LMMS, several people are currently targeting
master with pull requests... lots of things that will conflict.

Then again, there's never a really "good" time for this kind of stuff,
but still...

[lukas-w]

Yeah there's really never a good time for this. I know it's gonna be hell, but I think it only gets worse the longer we wait. The more work on lmms2 advances, the more conflicts. Better sooner than later.

Oh and thanks for the moral support. :)

[lukas-w]

I think I'm done.

[diizy]

Small nitpick here...

I wonder if BBEditor (BBTrack, BBTrackContainer etc.) should properly be
capitalized as:

BbEditor, BbTrack, etc.

By convention, we've usually treated abbreviations as one word, eg. Tco
instead of TCO... so to be consistent, should we maybe use Bb instead of BB?

[lukas-w]

By convention, we've usually treated abbreviations as one word, eg. Tco instead of TCO... so to be consistent, should we maybe use Bb instead of BB?

Ah I didn't know about that convention. I find Tco more confusing than TCO though. The latter makes it obvious that it's an abbreviation.

[diizy]

On 11/26/2014 02:06 PM, Lukas W wrote:

By convention, we've usually treated abbreviations as one word,
eg. Tco instead of TCO... so to be consistent, should we maybe use
Bb instead of BB?

Ah I didn't know about that convention. I find Tco more confusing than
TCO. The latter makes it obvious that it's an abbreviation.

On the other hand it maybe makes it simpler to remember how to
capitalize identifiers... like, if you remember the name of a
type/variable, but not how it's exactly spelled...

Well, it's not a big issue either way - most editors have autocomplete
these days so I guess the point is moot.

[lukas-w]

Well I'm fine with BbTrack and Tco as well, I guess that's more common. Feel free to change that.

[diizy]

Lukas you forgot to rename things in the CSS...

[lukas-w]

Nope, did that ad1e495

[lukas-w]

Ah, I didn't push that commit to lmms2, sorry. Just merge master and the theme will be fixed.

[diizy]

On 11/27/2014 05:41 PM, Lukas W wrote:

Ah, I didn't push that commit to |lmms2|, sorry. Just merge master and
the theme will be fixed.

No worries, I fixed it already in lmms2.