Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird buzzing in Monstro Osc 2 #7334

Closed
1 task done
JalvinGaming opened this issue Jun 20, 2024 · 5 comments · Fixed by #7368
Closed
1 task done

Weird buzzing in Monstro Osc 2 #7334

JalvinGaming opened this issue Jun 20, 2024 · 5 comments · Fixed by #7368
Labels
bug

Comments

@JalvinGaming
Copy link

JalvinGaming commented Jun 20, 2024 •
edited by zonkmachine
Loading

System Information

Windows 11, Intel i5-9600k, NVIDIA GeForce RTX 3070Ti, 32GB RAM

LMMS Version(s)

1.3.0-alpha.1.634+g2adbb166b

Bug Summary

The Monstro Instrument has a weird buzzing effect on Osc 2 that plays in the right ear.

Expected Behaviour

No buzz

Steps To Reproduce

Drag Monstro Instrument
Turn down Osc 1 and 3

Screenshots / Minimum Reproducible Project

monstrobuzz.mmp.txt

Please search the issue tracker for existing bug reports before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
@musikBear
Copy link

Cant reproduce
image
Default setup except the 3 OSCs
image
win10

@khoidauminh
Copy link
Contributor

I can reproduce this. Happens on the master branch
LMMS 1.3.0-alpha.1.654+g538572a3c (Linux x86_64, Qt 5.15.14, GCC 14.1.1 20240522)

@zonkmachine
Copy link
Member

Confirmed. This seem to have been introduced in c2f2b7e
@michaelgregorius

@zonkmachine
Copy link
Member

I added a project that demonstrates the issue in the first post.

michaelgregorius added a commit to michaelgregorius/lmms that referenced this issue Jul 5, 2024
@michaelgregorius
Fix buzz in Monstro's 2nd oscillator (LMMS#7334)
4a74d0d 
Fix a buzzing sound in Monstro's 2nd oscillator. It was introduced with
commit c2f2b7e.

The problem was caused by checking if `len_r` is not equal to 0 instead of
checking `pd_r`.
@michaelgregorius michaelgregorius mentioned this issue Jul 5, 2024
Merged
@michaelgregorius
Copy link
Contributor

Fixed with pull request #7368.

Rossmaxx pushed a commit that referenced this issue Jul 5, 2024
@michaelgregorius
Fix buzz in Monstro's 2nd oscillator (#7334) (#7368)
0384813 
Fix a buzzing sound in Monstro's 2nd oscillator. It was introduced with
commit c2f2b7e.

The problem was caused by checking if `len_r` is not equal to 0 instead of
checking `pd_r`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix buzz in Monstro's 2nd oscillator (#7334) michaelgregorius/lmms
5 participants
@zonkmachine @musikBear @michaelgregorius @JalvinGaming @khoidauminh