Can't give a segment the same name as the track

[gthzrsfk]

Affected LMMS versions

1.2.1

[Veratil]

This isn't a bug, but normal behavior.

[gthzrsfk]

But for what?
When I rename a track to the same name as a segment and the window of instrument (what do you call it? Which appears when I click the track name) is viewed, all the same of the segments disappear. Is that expected, too?

[Veratil]

It was done in this commit as part of this PR. As for why, I wasn't around then so I don't know. @PhysSong I see you were around when this PR was open, do you recall anything about this?

[PhysSong]

@Veratil No, it's was there way much before that PR.
dd1db7d

[Veratil]

Interesting. I don't see a reason why other than "improve appearance".

[zonkmachine]

Let me see If I get this right. When we create a new pattern we set the name to the track name here:

lmms/src/tracks/Pattern.cpp

Line 61 in a053061

setName( _instrument_track->name() );

Then some people think that's a bit spammy (I tend to agree with that after removing the code to filter out the track name), so we forbid lmms to write that name on the pattern. It's better to not set the pattern name to the track name in the first place if we don't want it there. I think this should be fixed somehow.

[zonkmachine]

Something like this. It will make a whole lot of tracks out there reveal hidden track names. I don't know what to do about that though.

(edit: please grab this code)

diff --git a/src/tracks/Pattern.cpp b/src/tracks/Pattern.cpp
index 26cc1c9..f6924cf 100644
--- a/src/tracks/Pattern.cpp
+++ b/src/tracks/Pattern.cpp
@@ -56,7 +56,6 @@ Pattern::Pattern( InstrumentTrack * _instrument_track ) :
        m_patternType( BeatPattern ),
        m_steps( MidiTime::stepsPerTact() )
 {
-       setName( _instrument_track->name() );
        if( _instrument_track->trackContainer()
                                        == Engine::getBBTrackContainer() )
        {
@@ -1049,12 +1048,7 @@ void PatternView::paintEvent( QPaintEvent * )
diff --git a/src/tracks/Pattern.cpp b/src/tracks/Pattern.cpp
index 26cc1c9..f6924cf 100644
--- a/src/tracks/Pattern.cpp
+++ b/src/tracks/Pattern.cpp
@@ -56,7 +56,6 @@ Pattern::Pattern( InstrumentTrack * _instrument_track ) :
        m_patternType( BeatPattern ),
        m_steps( MidiTime::stepsPerTact() )
 {
-       setName( _instrument_track->name() );
        if( _instrument_track->trackContainer()
                                        == Engine::getBBTrackContainer() )
        {
@@ -1049,12 +1048,7 @@ void PatternView::paintEvent( QPaintEvent * )
        // pattern name
        p.setRenderHint( QPainter::TextAntialiasing );
 
-       bool isDefaultName = m_pat->name() == m_pat->instrumentTrack()->name();
-
-       if( !isDefaultName && m_staticTextName.text() != m_pat->name() )
-       {
-               m_staticTextName.setText( m_pat->name() );
-       }
+       m_staticTextName.setText( m_pat->name() );
 
        QFont font;
        font.setHintingPreference( QFont::PreferFullHinting );
@@ -1064,13 +1058,10 @@ void PatternView::paintEvent( QPaintEvent * )
        const int textTop = TCO_BORDER_WIDTH + 1;
        const int textLeft = TCO_BORDER_WIDTH + 1;
 
-       if( !isDefaultName )
-       {
-               p.setPen( textShadowColor() );
-               p.drawStaticText( textLeft + 1, textTop + 1, m_staticTextName );
-               p.setPen( textColor() );
-               p.drawStaticText( textLeft, textTop, m_staticTextName );
-       }
+       p.setPen( textShadowColor() );
+       p.drawStaticText( textLeft + 1, textTop + 1, m_staticTextName );
+       p.setPen( textColor() );
+       p.drawStaticText( textLeft, textTop, m_staticTextName );
 
        // inner border
        if( !( fixedTCOs() && beatPattern ) )

[Spekular]

It will make a whole lot of tracks out there reveal hidden track names. I don't know what to do about that though.

Should be possible to write an upgrade routine that clears the pattern name if it matches the track name. It wouldn't break anything, since those names are already invisible the behavior is unchanged for existing projects.

[zonkmachine]

Yes. I have a rather poor track record with DataFile.cpp though, so I pass that on to someone else. ;)

[Spekular]

If anyone gets around to this before me, go ahead. Just assigning myself so I don't forget that I want to work on this.