Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckSubmodules always fetches WeakJack #3992

Closed
tresf opened this issue Nov 20, 2017 · 1 comment
Closed

CheckSubmodules always fetches WeakJack #3992

tresf opened this issue Nov 20, 2017 · 1 comment

Comments

@tresf
Copy link
Member

tresf commented Nov 20, 2017 •
edited
Loading

CheckSubmodules.cmake's logic for fetching submodules is currently flawed for WeakJack.

Per @PhysSong reported in #3970:

weakjack submodule doesn't have any files matches any globs in:

lmms/cmake/modules/CheckSubmodules.cmake

Line 21 in 5e2c105

SET(VALID_CRUMBS "CMakeLists.txt;Makefile;Makefile.in;Makefile.am;configure.ac;configure.py;autogen.sh")

@tresf tresf changed the title CheckSubmodule won't fetch WeakJack CheckSubmodules won't fetch WeakJack Nov 20, 2017
tresf added a commit to tresf/lmms that referenced this issue Nov 20, 2017
@tresf
Various CheckSubmodules fixes
3cf10d5 
Closes LMMS#3992, LMMS#3993, LMMS#3994
@tresf tresf changed the title CheckSubmodules won't fetch WeakJack CheckSubmodules always fetches WeakJack Nov 20, 2017
@tresf tresf mentioned this issue Nov 20, 2017
Merged
tresf added a commit that referenced this issue Nov 21, 2017
@tresf
Various CheckSubmodules fixes (#3996)
d634ed3 
Various CheckSubmodules fixes
Closes #3992, #3993, #3994
@tresf
Copy link
Member Author

tresf commented Nov 21, 2017

Closed via d634ed3.

@tresf tresf closed this as completed Nov 21, 2017
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
@tresf
Various CheckSubmodules fixes (LMMS#3996)
85c631c 
Various CheckSubmodules fixes
Closes LMMS#3992, LMMS#3993, LMMS#3994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tresf